Compare commits

...

2 Commits

Author SHA1 Message Date
John Congdon c81f18a3ef Reset the label when a S_DOT is encountered. (#297)
This will allow multi label domain's to still validate correctly.

Reset the label when a S_DOT is encountered.
2021-04-01 20:37:14 +02:00
Dries Vints 95979e2ad6 Add null return type to getError DocBlock (#293) 2021-03-11 14:36:15 +01:00
3 changed files with 3 additions and 2 deletions
+1 -1
View File
@@ -280,9 +280,9 @@ class DomainPart extends PartParser
{ {
if ($this->lexer->token['type'] === EmailLexer::S_DOT || $isEndOfDomain) { if ($this->lexer->token['type'] === EmailLexer::S_DOT || $isEndOfDomain) {
if ($this->isLabelTooLong($this->label)) { if ($this->isLabelTooLong($this->label)) {
$this->label = '';
return new InvalidEmail(new LabelTooLong(), $this->lexer->token['value']); return new InvalidEmail(new LabelTooLong(), $this->lexer->token['value']);
} }
$this->label = '';
} }
$this->label .= $this->lexer->token['value']; $this->label .= $this->lexer->token['value'];
return new ValidEmail(); return new ValidEmail();
+1 -1
View File
@@ -21,7 +21,7 @@ interface EmailValidation
/** /**
* Returns the validation error. * Returns the validation error.
* *
* @return InvalidEmail * @return InvalidEmail|null
*/ */
public function getError() : ?InvalidEmail; public function getError() : ?InvalidEmail;
@@ -76,6 +76,7 @@ class RFCValidationDomainPartTest extends TestCase
['validipv4@[127.0.0.0]'], ['validipv4@[127.0.0.0]'],
['validipv4@127.0.0.0'], ['validipv4@127.0.0.0'],
['withhyphen@domain-exam.com'], ['withhyphen@domain-exam.com'],
['valid_long_domain@71846jnrsoj91yfhc18rkbrf90ue3onl8y46js38kae8inz0t1.5a-xdycuau.na49.le.example.com']
); );
} }