Html Reader Converting Cell Containing 0 to Null String (#2813)

Browse Source

Fix #2810. Repairing some Phpstan diagnostics, used `?:` rather than `??` in a few places.

2 different Html modules are affected. Also, Ods Reader, but its problem is with sheet title rather than cell contents. And, as it turns out, Ods Reader was already not handling sheets with a title of `0` correctly - it made a truthy test before setting sheet title. That is now changed to truthy or numeric. Other readers are not susceptible to this problem. Tests are added.

...

This commit is contained in:

oleibman

2022-05-10 07:33:45 -07:00

committed by GitHub

parent b0bfdde164

commit 070bc68514

8 changed files with 66 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tests/data/Reader/Ods/issue.2810.ods

BIN

Binary file not shown.