Ods Reader Allow Omission of Some Page Settings Tags

Browse Source

Fix #4099. Ods Reader was expecting there to always be `header-style` and `footer-style` tags when `page-layout` tag is present, but these need not exist. It seemed like there might be other exposures along this line in `readPageSettingStyles`; rather than waiting for a problem report to show up for each, the code is updated to use `->item(0)` in place of `[0]` when appropriate, and make use of the nullsafe `?->` operator introduced with Php8.

...

This commit is contained in:

oleibman

2024-07-18 13:30:58 -07:00

parent 1b68270f80

commit 2952cf5526

3 changed files with 43 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

tests/data/Reader/Ods/issue.4099.ods

BIN

Binary file not shown.