Drop all Scrutinizer annotations

Because they tend to clutter our code a lot and unfortunately, there are
lots of false positives. Instead, it would probably be better to deal
with false positives out of band, via the Scrutinizer web UI.
This commit is contained in:
Adrien Crivelli
2023-09-20 17:53:47 +08:00
parent 07c60bac4a
commit 2a0a53cd6a
218 changed files with 493 additions and 732 deletions
@@ -17,31 +17,31 @@ class DeprecatedTest extends TestCase
{
public function testDeprecated(): void
{
self::assertSame('x', /** @scrutinizer ignore-deprecated */ TextData::TRIMNONPRINTABLE('x'));
self::assertSame('x y', /** @scrutinizer ignore-deprecated */ TextData::TRIMSPACES('x y'));
self::assertSame(48, /** @scrutinizer ignore-deprecated */ TextData::ASCIICODE('0'));
self::assertSame('abc', /** @scrutinizer ignore-deprecated */ TextData::CONCATENATE('a', 'b', 'c'));
self::assertSame('$1.00', /** @scrutinizer ignore-deprecated */ TextData::DOLLAR(1));
self::assertEquals(2, /** @scrutinizer ignore-deprecated */ TextData::SEARCHSENSITIVE('b', 'abc'));
self::assertEquals(2, /** @scrutinizer ignore-deprecated */ TextData::SEARCHINSENSITIVE('b', 'abc'));
self::assertSame('1.00', /** @scrutinizer ignore-deprecated */ TextData::FIXEDFORMAT(1));
self::assertSame('xyz', /** @scrutinizer ignore-deprecated */ TextData::LEFT('xyzw', 3));
self::assertSame('yz', /** @scrutinizer ignore-deprecated */ TextData::MID('xyzw', 2, 2));
self::assertSame('zw', /** @scrutinizer ignore-deprecated */ TextData::RIGHT('xyzw', 2));
self::assertSame(4, /** @scrutinizer ignore-deprecated */ TextData::STRINGLENGTH('xyzw'));
self::assertSame('xyzw', /** @scrutinizer ignore-deprecated */ TextData::LOWERCASE('Xyzw'));
self::assertSame('XYZW', /** @scrutinizer ignore-deprecated */ TextData::UPPERCASE('Xyzw'));
self::assertSame('Xyzw', /** @scrutinizer ignore-deprecated */ TextData::PROPERCASE('xyzw'));
self::assertSame('xabw', /** @scrutinizer ignore-deprecated */ TextData::REPLACE('xyzw', 2, 2, 'ab'));
self::assertSame('xyzw', /** @scrutinizer ignore-deprecated */ TextData::TEXTFORMAT('xyzw', '@'));
self::assertEquals(3, /** @scrutinizer ignore-deprecated */ TextData::VALUE('3'));
self::assertEquals(3, /** @scrutinizer ignore-deprecated */ TextData::NUMBERVALUE('3'));
self::assertTrue(/** @scrutinizer ignore-deprecated */ TextData::EXACT('3', '3'));
self::assertSame('a,b,c', /** @scrutinizer ignore-deprecated */ TextData::TEXTJOIN(',', true, 'a', 'b', 'c'));
self::assertSame('aaa', /** @scrutinizer ignore-deprecated */ TextData::builtinREPT('a', 3));
self::assertSame('ayxw', /** @scrutinizer ignore-deprecated */ TextData::SUBSTITUTE('xyxw', 'x', 'a', 1));
self::assertSame('1', /** @scrutinizer ignore-deprecated */ TextData::CHARACTER('49'));
self::assertSame('0', /** @scrutinizer ignore-deprecated */ TextData::CHARACTER('48'));
self::assertSame('xyz', /** @scrutinizer ignore-deprecated */ TextData::RETURNSTRING('xyz'));
self::assertSame('x', TextData::TRIMNONPRINTABLE('x'));
self::assertSame('x y', TextData::TRIMSPACES('x y'));
self::assertSame(48, TextData::ASCIICODE('0'));
self::assertSame('abc', TextData::CONCATENATE('a', 'b', 'c'));
self::assertSame('$1.00', TextData::DOLLAR(1));
self::assertEquals(2, TextData::SEARCHSENSITIVE('b', 'abc'));
self::assertEquals(2, TextData::SEARCHINSENSITIVE('b', 'abc'));
self::assertSame('1.00', TextData::FIXEDFORMAT(1));
self::assertSame('xyz', TextData::LEFT('xyzw', 3));
self::assertSame('yz', TextData::MID('xyzw', 2, 2));
self::assertSame('zw', TextData::RIGHT('xyzw', 2));
self::assertSame(4, TextData::STRINGLENGTH('xyzw'));
self::assertSame('xyzw', TextData::LOWERCASE('Xyzw'));
self::assertSame('XYZW', TextData::UPPERCASE('Xyzw'));
self::assertSame('Xyzw', TextData::PROPERCASE('xyzw'));
self::assertSame('xabw', TextData::REPLACE('xyzw', 2, 2, 'ab'));
self::assertSame('xyzw', TextData::TEXTFORMAT('xyzw', '@'));
self::assertEquals(3, TextData::VALUE('3'));
self::assertEquals(3, TextData::NUMBERVALUE('3'));
self::assertTrue(TextData::EXACT('3', '3'));
self::assertSame('a,b,c', TextData::TEXTJOIN(',', true, 'a', 'b', 'c'));
self::assertSame('aaa', TextData::builtinREPT('a', 3));
self::assertSame('ayxw', TextData::SUBSTITUTE('xyxw', 'x', 'a', 1));
self::assertSame('1', TextData::CHARACTER('49'));
self::assertSame('0', TextData::CHARACTER('48'));
self::assertSame('xyz', TextData::RETURNSTRING('xyz'));
}
}