geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-10-10 05:46:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate Unneeded Separate Process Tests

Browse Source 
The tests stay; they just no longer run in separate processes. I think that only 2 tests still require separate processes - Helper/SampleTest and Tcpdf/NoDieTest. Aside from a new internal method in IOFactory, all the changes here are to test members.
This commit is contained in:
oleibman
2025-12-07 23:15:01 -08:00
parent f1ab77698e
commit 2c8177a319
19 changed files with 110 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php
+5 -10
View File
@@ -29,8 +29,7 @@ class HtmlImage2Test extends TestCase
<td><img src="' . $imagePath . '" alt="test image voilà"></td>
</tr>
</table>';
$filename = HtmlHelper::createHtml($html);
$spreadsheet = HtmlHelper::loadHtmlIntoSpreadsheet($filename, true, true);
$spreadsheet = HtmlHelper::loadHtmlStringIntoSpreadsheet($html, true);
$firstSheet = $spreadsheet->getSheet(0);
/** @var Drawing $drawing */
@@ -48,8 +47,7 @@ class HtmlImage2Test extends TestCase
<td><img src="' . $imagePath . '" alt="test image voilà"></td>
</tr>
</table>';
$filename = HtmlHelper::createHtml($html);
$spreadsheet = HtmlHelper::loadHtmlIntoSpreadsheet($filename, true, false);
$spreadsheet = HtmlHelper::loadHtmlStringIntoSpreadsheet($html, false);
$firstSheet = $spreadsheet->getSheet(0);
self::assertCount(0, $firstSheet->getDrawingCollection());
$spreadsheet->disconnectWorksheets();
@@ -66,8 +64,7 @@ class HtmlImage2Test extends TestCase
<td><img src="' . $imagePath . '" alt="test image voilà"></td>
</tr>
</table>';
$filename = HtmlHelper::createHtml($html);
$spreadsheet = HtmlHelper::loadHtmlIntoSpreadsheet($filename, true, true);
$spreadsheet = HtmlHelper::loadHtmlStringIntoSpreadsheet($html, true);
$firstSheet = $spreadsheet->getSheet(0);
$drawingCollection = $firstSheet->getDrawingCollection();
self::assertCount(0, $drawingCollection);
@@ -82,8 +79,7 @@ class HtmlImage2Test extends TestCase
<td><img src="' . $imagePath . '" alt="test image voilà"></td>
</tr>
</table>';
$filename = HtmlHelper::createHtml($html);
$spreadsheet = HtmlHelper::loadHtmlIntoSpreadsheet($filename, true, false);
$spreadsheet = HtmlHelper::loadHtmlStringIntoSpreadsheet($html, false);
$firstSheet = $spreadsheet->getSheet(0);
$drawingCollection = $firstSheet->getDrawingCollection();
self::assertCount(0, $drawingCollection);
@@ -100,8 +96,7 @@ class HtmlImage2Test extends TestCase
<td><img src="' . $imagePath . '" alt="test image voilà"></td>
</tr>
</table>';
$filename = HtmlHelper::createHtml($html);
HtmlHelper::loadHtmlIntoSpreadsheet($filename, true);
HtmlHelper::loadHtmlStringIntoSpreadsheet($html);
}
public static function providerBadProtocol(): array