From 4b655ea5a83847aa454ee3ccd2c403028cac310d Mon Sep 17 00:00:00 2001 From: oleibman <10341515+oleibman@users.noreply.github.com> Date: Mon, 1 Jan 2024 23:02:44 -0800 Subject: [PATCH] Php-cs-fixer Command Change PR #3852 was a bit strange. Php-cs-fixer complained about a problem that I could not reproduce on my local system, and it didn't really produce sufficient output to correct whatever the problem was. I was able to guess it eventually, but I need to see if there's a way to get it to be more forthcoming. --- .github/workflows/main.yml | 2 +- src/PhpSpreadsheet/CellReferenceHelper.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ac78fe14c..19b678ea3 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -112,7 +112,7 @@ jobs: run: composer install --no-progress --prefer-dist --optimize-autoloader - name: Code style with PHP-CS-Fixer - run: ./vendor/bin/php-cs-fixer fix --format=checkstyle | cs2pr + run: ./vendor/bin/php-cs-fixer fix --format=checkstyle --diff --dry-run | cs2pr phpcs: runs-on: ubuntu-latest diff --git a/src/PhpSpreadsheet/CellReferenceHelper.php b/src/PhpSpreadsheet/CellReferenceHelper.php index b2f18f6dd..5dc9aa8e0 100644 --- a/src/PhpSpreadsheet/CellReferenceHelper.php +++ b/src/PhpSpreadsheet/CellReferenceHelper.php @@ -24,7 +24,7 @@ class CellReferenceHelper $this->numberOfRows = $numberOfRows; // Get coordinate of $beforeCellAddress - [$beforeColumn, $beforeRow] = Coordinate::coordinateFromString($beforeCellAddress); + [$beforeColumn, $beforeRow] = \PhpOffice\PhpSpreadsheet\Cell\Coordinate::coordinateFromString($beforeCellAddress); $this->beforeColumn = Coordinate::columnIndexFromString($beforeColumn); $this->beforeRow = (int) $beforeRow; }