geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-22 16:19:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deleting Sheet with Local Defined Name (#2284)

Browse Source 
Fixes issue #2266. Writer/Xlsx fails when there is no longer a sheet which corresponds to the definition of a local defined name. The code is changed to drop such an orphaned name. Writer/Xls does not fail under the same cicrcumstances, so no correction is needed there. Writer/Ods fails in a different manner, and is corrected to no longer do so.
This commit is contained in:
oleibman
2021-09-15 12:14:13 -07:00
committed by GitHub
parent e02eab29f1
commit 4dd5c06c7b
5 changed files with 84 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Writer/Xlsx/Issue2266Test.php
+46
View File
@@ -0,0 +1,46 @@
<?php
namespace PhpOffice\PhpSpreadsheetTests\Writer\Xlsx;
use PhpOffice\PhpSpreadsheet\Reader\Xlsx as Reader;
use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;
class Issue2266Test extends AbstractFunctional
{
/**
* @dataProvider providerType
*/
public function testIssue2266(string $type): void
{
// Problem deleting sheet containing local defined name.
$reader = new Reader();
$spreadsheet = $reader->load('tests/data/Writer/XLSX/issue.2266f.xlsx');
self::assertCount(2, $spreadsheet->getAllSheets());
self::assertCount(1, $spreadsheet->getDefinedNames());
$index = 1;
$sheet = $spreadsheet->getSheet($index);
self::assertSame('Sheet2', $sheet->getTitle());
$definedName = $spreadsheet->getDefinedName('LocalName', $sheet);
self::assertNotNull($definedName);
self::assertTrue($definedName->getLocalOnly());
$spreadsheet->removeSheetByIndex($index);
$reloadedSpreadsheet = $this->writeAndReload($spreadsheet, $type);
$spreadsheet->disconnectWorksheets();
self::assertCount(1, $reloadedSpreadsheet->getAllSheets());
self::assertCount(0, $reloadedSpreadsheet->getDefinedNames());
self::assertNotEquals('Sheet2', $reloadedSpreadsheet->getSheet(0)->getTitle());
$reloadedSpreadsheet->disconnectWorksheets();
}
public function providerType(): array
{
return [
['Xlsx'],
['Xls'],
['Ods'],
];
}
}