From 50654a3e6971642408ef012c4fa78fafb2961dda Mon Sep 17 00:00:00 2001 From: oleibman <10341515+oleibman@users.noreply.github.com> Date: Mon, 10 Aug 2026 07:14:22 -0700 Subject: [PATCH] Add Xls to Sample 25 --- samples/Basic2/25_In_memory_image.php | 2 +- src/PhpSpreadsheet/Writer/Xls/Worksheet.php | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/samples/Basic2/25_In_memory_image.php b/samples/Basic2/25_In_memory_image.php index a18880eae..b798c8472 100644 --- a/samples/Basic2/25_In_memory_image.php +++ b/samples/Basic2/25_In_memory_image.php @@ -101,7 +101,7 @@ $drawing->setCoordinates('C5'); $helper->write( $spreadsheet, __FILE__, - ['Xlsx', 'Html', 'Ods'], + ['Xlsx', 'Html', 'Ods', 'Xls'], false, function (BaseWriter $writer): void { if (method_exists($writer, 'writeAllSheets')) { diff --git a/src/PhpSpreadsheet/Writer/Xls/Worksheet.php b/src/PhpSpreadsheet/Writer/Xls/Worksheet.php index bd40f8ada..941ae9f7a 100644 --- a/src/PhpSpreadsheet/Writer/Xls/Worksheet.php +++ b/src/PhpSpreadsheet/Writer/Xls/Worksheet.php @@ -484,6 +484,9 @@ class Worksheet extends BIFFwriter [$column, $row] = Coordinate::indexesFromString($coordinate); $url = $hyperlink->getUrl(); + if ($url === '') { + continue; + } if ($url[0] === '#') { $url = "internal:$url"; } elseif (str_starts_with($url, 'sheet://')) {