geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-08-31 04:28:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better Workaround for Versions "Error"

Browse Source 
PHPCompatibility (versions check) erroneously flags the use of $this in enumerations. They fixed it in their development branch in October 2022. But they haven't had a release since 2019!
This commit is contained in:
oleibman
2024-08-11 08:24:27 -07:00
parent 56ecfa2b2a
commit 5e248cf12d
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/main.yml
+1 -1
View File
@@ -173,7 +173,7 @@ jobs:
run: composer install --no-progress --prefer-dist --optimize-autoloader run: composer install --no-progress --prefer-dist --optimize-autoloader
- name: Code Version Compatibility check with PHP_CodeSniffer - name: Code Version Compatibility check with PHP_CodeSniffer
run: ./vendor/bin/phpcs -q --report-width=200 --report=summary,full src/ --standard=PHPCompatibility --runtime-set testVersion 8.1- run: ./vendor/bin/phpcs -q --report-width=200 --report=summary,full src/ --standard=PHPCompatibility --runtime-set testVersion 8.1- --exclude=PHPCompatibility.Variables.ForbiddenThisUseContexts
phpstan: phpstan:
runs-on: ubuntu-latest runs-on: ubuntu-latest
src/PhpSpreadsheet/Style/NumberFormat/Wizard/CurrencyNegative.php
-7
View File
@@ -4,17 +4,11 @@ namespace PhpOffice\PhpSpreadsheet\Style\NumberFormat\Wizard;
enum CurrencyNegative enum CurrencyNegative
{ {
// PHPCompatibility (versions check) has an error which
// causes it to flag the use of $this below as erroneous.
// They fixed it in their development branch in October 2022.
// But they haven't had a release since 2019!
// Hence the phpcs disable statment below.
case minus; case minus;
case redMinus; case redMinus;
case parentheses; case parentheses;
case redParentheses; case redParentheses;
// phpcs:disable PHPCompatibility.Variables.ForbiddenThisUseContexts
public function start(): string public function start(): string
{ {
return match ($this) { return match ($this) {
@@ -38,5 +32,4 @@ enum CurrencyNegative
self::parentheses, self::minus => '', self::parentheses, self::minus => '',
}; };
} }
// phpcs:enable
} }