geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-10-03 18:39:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use calculateFormula Rather Than _calculateFormulaValue in Tests

Browse Source 
They aren't quite interchangeable. Both are used in the test suite, with no indication of why one or the other. I think we'd be best off being consistent. Based on the names, I think `_calculateFormulaValue` was intended as a private, or at least internal, method, so favor `calculateFormula`. I do not intend to rename or re-categorize `_calculateFormulaValue`, just remove its usage when it isn't clearly warranted.
This commit is contained in:
oleibman
2025-11-13 20:48:46 -08:00
parent a61f9f1b66
commit 70b4ecd4d3
168 changed files with 301 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Calculation/Functions/TextData/TextJoinTest.php
+2 -2
View File
@@ -42,8 +42,8 @@ class TextJoinTest extends AllSetupTeardown
$calculation = Calculation::getInstance();
$formula = "=TEXTJOIN({$delimiter}, {$blanks}, {$texts})";
$result = $calculation->_calculateFormulaValue($formula);
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-14);
$result = $calculation->calculateFormula($formula);
self::assertSame($expectedResult, $result);
}
public static function providerTextjoinArray(): array