geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-22 08:09:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize applyFromArray by caching existing styles (#1785)

Browse Source 
Prevent calling clone and getHashCode when not needed
because these calls are very expensive.

When applying styles to a range of cells can we cache the
styles we encounter along the way so we don't need to look
them up with getHashCode later.
This commit is contained in:
Einar
2021-10-30 17:55:00 +02:00
committed by GitHub
parent 5b4b12f77b
commit 7635b3f91a
3 changed files with 102 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Style/StyleTest.php
+23
View File
@@ -55,6 +55,29 @@ class StyleTest extends TestCase
self::assertFalse($sheet->getStyle('C3')->getFont()->getItalic());
}
public function testStyleIsReused(): void
{
$spreadsheet = new Spreadsheet();
$sheet = $spreadsheet->getActiveSheet();
$styleArray = [
'font' => [
'italic' => true,
],
];
$sheet->getStyle('A1')->getFont()->setBold(true);
$sheet->getStyle('A2')->getFont()->setBold(true);
$sheet->getStyle('A3')->getFont()->setBold(true);
$sheet->getStyle('A3')->getFont()->setItalic(true);
$sheet->getStyle('A')->applyFromArray($styleArray);
self::assertCount(4, $spreadsheet->getCellXfCollection());
$spreadsheet->garbageCollect();
self::assertCount(3, $spreadsheet->getCellXfCollection());
}
public function testStyleRow(): void
{
$spreadsheet = new Spreadsheet();