geckon01/PhpSpreadsheet
1
0
Fork 0
mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-09-17 13:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better Definitions for Mixed Parameters and Values Part 4 of Many

Browse Source 
Continuing work started with PR #4016, PR #4026, and PR #4060. Improve documentation within program by making explicit what types of values are allowed for variables described as "mixed". In order to avoid broken functionality, this is done mainly through doc-blocks. This will get us closer to Phpstan Level 9, but many changes will be needed before we can consider that.

After this PR, 231 changes remain, all in src/Calculation.
This commit is contained in:
Owen Leibman
2024-08-24 22:08:13 -07:00
parent e1dae99a70
commit 826451937e
9 changed files with 65 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/PhpSpreadsheetTests/Reader/Gnumeric/ArrayFormulaTest.php
+1 -1
View File
@@ -30,7 +30,7 @@ class ArrayFormulaTest extends TestCase
} else {
self::assertEmpty($cell->getFormulaAttributes());
}
self::assertSame($expectedFormula, strtoupper($cell->getValue()));
self::assertSame($expectedFormula, strtoupper($cell->getValueString()));
Calculation::getInstance($spreadsheet)->setInstanceArrayReturnType(Calculation::RETURN_ARRAY_AS_ARRAY);
$worksheet->calculateArrays();
$cell = $worksheet->getCell($cellAddress);