From beb0ac856a9fefbc5ccc3b69394eea25a27fbfd1 Mon Sep 17 00:00:00 2001 From: oleibman <10341515+oleibman@users.noreply.github.com> Date: Wed, 11 Dec 2024 06:21:20 -0800 Subject: [PATCH] Disable 2 Tests For the second time in recent months, some tests are failing/erring because https file_get_contents is not working on github (cannot reproduce locally on Windows or Linux). Filed an issue with Php when this first happened, and their suggested code change worked till now. If they come up with another successful code change, I will implement it and restore these tests. --- tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php | 4 ++-- tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php b/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php index 33dee3108..67e193237 100644 --- a/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php +++ b/tests/PhpSpreadsheetTests/Reader/Html/HtmlImage2Test.php @@ -10,7 +10,7 @@ use PHPUnit\Framework\TestCase; class HtmlImage2Test extends TestCase { - public function testCanInsertImageGoodProtocol(): void + public function xtestCanInsertImageGoodProtocol(): void { if (getenv('SKIP_URL_IMAGE_TEST') === '1') { self::markTestSkipped('Skipped due to setting of environment variable'); @@ -31,7 +31,7 @@ class HtmlImage2Test extends TestCase self::assertEquals('A1', $drawing->getCoordinates()); } - public function testCantInsertImageNotFound(): void + public function xtestCantInsertImageNotFound(): void { if (getenv('SKIP_URL_IMAGE_TEST') === '1') { self::markTestSkipped('Skipped due to setting of environment variable'); diff --git a/tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php b/tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php index e715621d3..40d8a571b 100644 --- a/tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php +++ b/tests/PhpSpreadsheetTests/Reader/Xlsx/URLImageTest.php @@ -12,7 +12,7 @@ use PHPUnit\Framework\TestCase; class URLImageTest extends TestCase { - public function testURLImageSource(): void + public function xtestURLImageSource(): void { if (getenv('SKIP_URL_IMAGE_TEST') === '1') { self::markTestSkipped('Skipped due to setting of environment variable'); @@ -37,7 +37,7 @@ class URLImageTest extends TestCase $spreadsheet->disconnectWorksheets(); } - public function testURLImageSourceNotFound(): void + public function xtestURLImageSourceNotFound(): void { if (getenv('SKIP_URL_IMAGE_TEST') === '1') { self::markTestSkipped('Skipped due to setting of environment variable');