mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-21 15:49:26 +00:00
Use Php Attributes Rather than Annotations for PhpUnit
With PhpUnit 10 came the ability to use Php attributes rather than doc-block annotations for things like "data provider". PhpUnit 11 deprecates the use of annotations, and PhpUnit 12 will not not permit their use. Since PhpUnit 11 requires Php8.2+, we cannot adopt it as long as we support Php8.1, which will continue to be the case for some time. However, there is no penalty for early adoption. Php-cs-fixer can use: ``` 'php_unit_attributes' => ['keep_annotations' => false], ``` This allows us to run `composer fix` to automate all the needed changes. No manual changes were needed for any of the test members. With this change, PhpUnit 9 can no longer be used with the test suite. File composer.json is updated to reflect that reality, and phpunit9.xml.dist, which has been supplied in case anyone needed to use PhpUnit 9, is no longer required, and is thus deleted. For now, PhpUnit 11 is not being added as a possibility. No source code is changed in this PR.
This commit is contained in:
@@ -11,11 +11,10 @@ use PhpOffice\PhpSpreadsheet\Settings;
|
||||
class LeftTest extends AllSetupTeardown
|
||||
{
|
||||
/**
|
||||
* @dataProvider providerLEFT
|
||||
*
|
||||
* @param mixed $str string from which to extract
|
||||
* @param mixed $cnt number of characters to extract
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerLEFT')]
|
||||
public function testLEFT(mixed $expectedResult, mixed $str = 'omitted', mixed $cnt = 'omitted'): void
|
||||
{
|
||||
$this->mightHaveException($expectedResult);
|
||||
@@ -39,9 +38,7 @@ class LeftTest extends AllSetupTeardown
|
||||
return require 'tests/data/Calculation/TextData/LEFT.php';
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider providerLocaleLEFT
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerLocaleLEFT')]
|
||||
public function testLowerWithLocaleBoolean(string $expectedResult, string $locale, mixed $value, mixed $characters): void
|
||||
{
|
||||
$newLocale = Settings::setLocale($locale);
|
||||
@@ -71,9 +68,7 @@ class LeftTest extends AllSetupTeardown
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider providerCalculationTypeLEFTTrue
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerCalculationTypeLEFTTrue')]
|
||||
public function testCalculationTypeTrue(string $type, string $resultB1, string $resultB2): void
|
||||
{
|
||||
Functions::setCompatibilityMode($type);
|
||||
@@ -107,9 +102,7 @@ class LeftTest extends AllSetupTeardown
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider providerCalculationTypeLEFTFalse
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerCalculationTypeLEFTFalse')]
|
||||
public function testCalculationTypeFalse(string $type, string $resultB1, string $resultB2): void
|
||||
{
|
||||
Functions::setCompatibilityMode($type);
|
||||
@@ -143,9 +136,7 @@ class LeftTest extends AllSetupTeardown
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider providerCalculationTypeLEFTNull
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerCalculationTypeLEFTNull')]
|
||||
public function testCalculationTypeNull(string $type, string $resultB1, string $resultB2): void
|
||||
{
|
||||
Functions::setCompatibilityMode($type);
|
||||
@@ -178,9 +169,7 @@ class LeftTest extends AllSetupTeardown
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @dataProvider providerLeftArray
|
||||
*/
|
||||
#[\PHPUnit\Framework\Attributes\DataProvider('providerLeftArray')]
|
||||
public function testLeftArray(array $expectedResult, string $argument1, string $argument2): void
|
||||
{
|
||||
$calculation = Calculation::getInstance();
|
||||
|
||||
Reference in New Issue
Block a user