11 Commits

Author	SHA1	Message	Date
MarkBaker	fe4808b3d5	Merge branch 'master' into 2.0-Development ... # Conflicts: # composer.lock # tests/PhpSpreadsheetTests/Calculation/Functions/LookupRef/VLookupTest.php	2022-08-03 14:03:43 +02:00
oleibman	4bf4278a39	VLOOKUP Breaks When Array Contains Null Cells (#2939) ... Fix #2934. Null is passed to StringHelper::strtolower which expects string. Same problem appears to be applicable to HLOOKUP. I noted the following problem in the code, but will document it here as well. Excel's results are not consistent when a non-numeric string is passed as the third parameter. For example, if cell Z1 contains `xyz`, Excel will return a REF error for function `VLOOKUP(whatever,whatever,Z1)`, but it returns a VALUE error for function `VLOOKUP(whatever,whatever,"xyz")`. I don't think PhpSpreadsheet can match both behaviors. For now, it will return VALUE for both, with similar results for other errors. While studying the returned errors, I realized there is something that needs to be deprecated. `ExcelError::$errorCodes` is a public static array. This means that a user can change its value, which should not be allowed. It is replaced by a constant. Since the original is public, I think it needs to stay, but with a deprecation notice; users can reference and change it, but it will be unused in the rest of the code. I suppose this might be considered a break in functionality (that should not have been allowed in the first place).	2022-07-17 06:27:56 -07:00
MarkBaker	0998e72a2e	Eliminate underscore prefix in method names... no longer needed as an indicator that a method should be internal only	2022-04-26 22:40:10 +02:00
MarkBaker	e41c4280f6	Initial creation of the version 2.0 Development branch ... Start removing some of the deprecations, starting with the old Excel Function implementations.	2022-04-25 10:30:45 +02:00
Mark Baker	c9f948bd91	Initial work on implementing Array-enabled for the HLOOKUP() and VLOOKUP() functions (#2611) ... * Initial work on implementing Array-enabled for the HLOOKUP() and VLOOKUP() functions * In the MATCH() function, we should also use `evaluateArrayArgumentsIgnore()` because the lookupvalue and matchType arguments can be array arguments, but lookupArray is always a dataset matrix	2022-02-21 19:56:21 +01:00
Adrien Crivelli	49f87de165	Reduce PHPStan error in tests	2021-04-12 11:10:23 +09:00
Adrien Crivelli	fcd9f10663	Update PHP-CS-Fixer rules	2020-05-18 13:49:57 +09:00
Adrien Crivelli	e868e58d20	Allow to run an entire folder of tests ... We now can do something like: ```sh ./vendor/bin/phpunit tests/PhpSpreadsheetTests/Reader/ ```	2020-05-17 18:35:55 +09:00
Adrien Crivelli	f1a019e492	Upgrad PHP deps	2020-04-27 19:29:45 +09:00
MarkBaker	f14e5ea837	More refactoring Excel of Calculation Function Unit Tests	2019-07-27 16:35:27 +02:00
MarkBaker	905a697639	More work on refactoring Excel Calculation Function Unit Tests	2019-07-27 16:02:58 +02:00