17 Commits

Author SHA1 Message Date
oleibman 974b349dc5 Close One Other Possible Vector 2026-05-28 13:50:08 -07:00
oleibman 2b89a7bb7a Block Phar Only 2026-05-23 19:47:24 -07:00
oleibman 0d9203b6b2 Reject phar Protocol in Unexpected Format
Reject `phar:///whatever` as input filename.
2026-05-14 21:26:12 -07:00
oleibman 50a7552f12 Option to Whitelist External Images
Loading external images from a spreadsheet can subject the caller to security exploits. For those who think they need something between not loading any external images (the default and our strong recommendation) or loading them all unconditionally (the current alternative), a callback can now be provided to indicate whether a specific image is okay to load. We continue to urge caution in using this option.
2026-01-30 22:43:21 -08:00
oleibman 2c8177a319 Eliminate Unneeded Separate Process Tests
The tests stay; they just no longer run in separate processes. I think that only 2 tests still require separate processes - Helper/SampleTest and Tcpdf/NoDieTest. Aside from a new internal method in IOFactory, all the changes here are to test members.
2025-12-07 23:15:01 -08:00
oleibman ac4befd2f7 Merge commit from fork 2025-08-02 18:06:29 -07:00
oleibman a9c6cbe146 All Readers - Allow or Forbid Fetching of External Images
Add to all readers the option to allow or forbid fetching external images. This is unconditionally allowed now. The default will be set to "allow", so no code changes are necessary. However, we are giving consideration to changing the default.
2025-07-18 21:22:09 -07:00
oleibman fc9f9858f1 Merge branch 'master' into pr1449 2025-02-07 18:04:58 -08:00
oleibman cde2926a9e Merge commit from fork
* Security Patch

Control characters should not be allowed in protocol.

* Tighten Up Drawing

* Fix Test
2025-01-23 21:25:36 -08:00
oleibman ff405d6032 Merge branch 'master' into pr1449 2024-12-26 22:35:56 -08:00
oleibman 3078ea9f87 Additional Context Options for https, Restore Disabled Tests
Additional Context Options needed, at least sometimes, to read https images.
2024-12-12 00:10:02 -08:00
oleibman 727f06ea24 Merge branch 'master' into pr1449 2024-12-11 06:35:47 -08:00
oleibman beb0ac856a Disable 2 Tests
For the second time in recent months, some tests are failing/erring because https file_get_contents is not working on github (cannot reproduce locally on Windows or Linux). Filed an issue with Php when this first happened, and their suggested code change worked till now. If they come up with another successful code change, I will implement it and restore these tests.
2024-12-11 06:21:20 -08:00
oleibman d1e466d154 Update HtmlImage2Test.php 2024-12-11 05:28:48 -08:00
oleibman bdc468063e More Tests 2024-08-18 19:32:27 -07:00
oleibman 5cd6b8870c Fix Minor Scrutinizer Complaint 2024-08-17 19:48:58 -07:00
oleibman e312656e3d Restrict Internet Protocols for Linked Images
Do not allow use of Php propietary protocols to retrieve linked images. Restrict to http, https, ftp, file, and s3.
2024-08-17 19:25:18 -07:00