Commit Graph

252 Commits

Author SHA1 Message Date
oleibman 5c94de34a9 More Phpstan Level 10 Prep - Readers
Also upgrade Phpstan.
2025-05-03 21:18:55 -07:00
oleibman 7fb9a5a1aa Merge branch 'master' into stan2lv909 2025-04-01 07:04:48 -07:00
oleibman b8bba641bb Merge pull request #4430 from PHPOffice/dependabot/composer/friendsofphp/php-cs-fixer-3.75.0
Bump friendsofphp/php-cs-fixer from 3.70.0 to 3.75.0
2025-04-01 13:50:12 +00:00
oleibman 156890d1ed Merge pull request #4432 from PHPOffice/dependabot/composer/squizlabs/php_codesniffer-3.12.0
Bump squizlabs/php_codesniffer from 3.11.3 to 3.12.0
2025-04-01 13:49:23 +00:00
dependabot[bot] 349e338993 Bump tecnickcom/tcpdf from 6.8.2 to 6.9.0
Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.8.2 to 6.9.0.
- [Changelog](https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT)
- [Commits](https://github.com/tecnickcom/TCPDF/compare/6.8.2...6.9.0)

---
updated-dependencies:
- dependency-name: tecnickcom/tcpdf
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-01 11:45:38 +00:00
dependabot[bot] 5b3bd85d29 Bump squizlabs/php_codesniffer from 3.11.3 to 3.12.0
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.11.3 to 3.12.0.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.11.3...3.12.0)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-01 11:45:27 +00:00
dependabot[bot] 4175edc5d4 Bump friendsofphp/php-cs-fixer from 3.70.0 to 3.75.0
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.70.0 to 3.75.0.
- [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/compare/v3.70.0...v3.75.0)

---
updated-dependencies:
- dependency-name: friendsofphp/php-cs-fixer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-01 11:45:19 +00:00
oleibman e32447c4be Phpstan Level 9: Last 2025-03-31 21:53:47 -07:00
oleibman 875dc354f9 Merge pull request #4384 from oleibman/stan2new
Phpstan V2
2025-03-02 07:05:51 +00:00
dependabot[bot] 0cac522ca5 Bump friendsofphp/php-cs-fixer from 3.68.5 to 3.70.0
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.68.5 to 3.70.0.
- [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/compare/v3.68.5...v3.70.0)

---
updated-dependencies:
- dependency-name: friendsofphp/php-cs-fixer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-01 11:19:12 +00:00
oleibman a2040b88b5 Phpstan V2 2025-02-26 14:18:58 -08:00
oleibman 4bbbbac700 Upgrade Phpstan
Prepatory to switching to "bleeding edge", necessary for Phpstan V2.
2025-02-07 20:58:37 -08:00
oleibman dd600fe621 Merge pull request #4338 from PHPOffice/dependabot/composer/friendsofphp/php-cs-fixer-3.68.5
Bump friendsofphp/php-cs-fixer from 3.66.0 to 3.68.5
2025-02-01 15:43:18 +00:00
oleibman 6523dc7ef0 Merge pull request #4337 from PHPOffice/dependabot/composer/dompdf/dompdf-3.1.0
Bump dompdf/dompdf from 3.0.2 to 3.1.0
2025-02-01 15:42:43 +00:00
oleibman fcc8ade7fe Merge pull request #4336 from PHPOffice/dependabot/composer/tecnickcom/tcpdf-6.8.2
Bump tecnickcom/tcpdf from 6.8.0 to 6.8.2
2025-02-01 15:42:09 +00:00
dependabot[bot] 1e4beba5e4 Bump friendsofphp/php-cs-fixer from 3.66.0 to 3.68.5
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.66.0 to 3.68.5.
- [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/compare/v3.66.0...v3.68.5)

---
updated-dependencies:
- dependency-name: friendsofphp/php-cs-fixer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-01 11:35:11 +00:00
dependabot[bot] 1a9000a649 Bump dompdf/dompdf from 3.0.2 to 3.1.0
Bumps [dompdf/dompdf](https://github.com/dompdf/dompdf) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/dompdf/dompdf/releases)
- [Commits](https://github.com/dompdf/dompdf/compare/v3.0.2...v3.1.0)

---
updated-dependencies:
- dependency-name: dompdf/dompdf
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-01 11:35:02 +00:00
dependabot[bot] 793075a97e Bump tecnickcom/tcpdf from 6.8.0 to 6.8.2
Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.8.0 to 6.8.2.
- [Changelog](https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT)
- [Commits](https://github.com/tecnickcom/TCPDF/compare/6.8.0...6.8.2)

---
updated-dependencies:
- dependency-name: tecnickcom/tcpdf
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-01 11:34:58 +00:00
dependabot[bot] ba7976c1cc Bump squizlabs/php_codesniffer from 3.11.2 to 3.11.3
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.11.2 to 3.11.3.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.11.2...3.11.3)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-01 11:34:55 +00:00
oleibman dfd8f3c40f Merge branch 'master' into comppcre 2025-01-21 15:07:32 -08:00
oleibman 9b122cd028 Use Composer/Pcre Part 1 of Many
The native preg functions (preg_match, preg_replace, etc.) often require us to add a lot of useless boilerplate code to satisfy Phpstan, Scrutinizer, etc. Composer/Pcre offers us a way to remove that boilerplate, thereby giving us a cleaner codebase. I decided to try it on a few modules, and saw a result that clearly demonstrated the usefulness of doing this (aside from the cleaner codebase).

Sample 22_Reader_issue1767 reads an Xlsx spreadsheet with complex sheet names used in defined names, and writes it to Xlsx and Xls output files. When I changed Writer/Xls/Parser to use Composer/Pcre, this sample failed in many different places writing the Xls file. It turns out that some regexes were failing not because the string didn't match, but because the regex encountered "catastrophic backtracing". Composer/Pcre throws an exception when this happens; the native preg_match does return false, but we were not checking for that. The regexes in question are now changed to something which works, and formal unit tests are added for them. Finding this previously undetected error indicates that we should proceed with this change.

An alternative to using Composer/Pcre would be to test for false after all the preg calls. I have done this in the two samples changed with this PR. That seems adequate for a small number of changes, but it really just makes for more clutter considering the large number of regexps that we use in our code. I think Composer/Pcre is a better choice.

It isn't quite transparent. Composer forces all regexps to use PREG_UNMATCHED_AS_NULL, so some match fields will now be null instead of null-string (or non-existent if the unmatched field comes at the end). Our test suite doesn't report any problem (yet) due to this change, although Phpstan is sensitive to it. Several Phpstan annotations were eliminated due to this change, but some others are now needed.

It is not necessary to do this all at once. This PR addresses all the calls in Writer. I intend to address other components in several tickets.
2025-01-17 09:44:45 -08:00
oleibman 7e24333f72 Upgrade mitoteam/jpgraph
They have made a change at our request to help us eliminate runInSeparateProcess for one or more tests. This will be helpful when we get to PhpUnit 11 (not imminent, since it doesn't support Php8.1, but it will happen eventually).
2025-01-02 09:59:34 -08:00
oleibman 14c6446715 Upgrade php-cs-fixer
Dependabot wanted to do this (PR #4296), but code changes were needed to pass.
2025-01-01 09:26:41 -08:00
oleibman 22478638ae Merge pull request #4295 from PHPOffice/dependabot/composer/squizlabs/php_codesniffer-3.11.2
Bump squizlabs/php_codesniffer from 3.11.1 to 3.11.2
2025-01-01 16:15:40 +00:00
dependabot[bot] eec2d9caaf Bump squizlabs/php_codesniffer from 3.11.1 to 3.11.2
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.11.1...3.11.2)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-01 11:43:41 +00:00
dependabot[bot] e68da428a4 Bump dompdf/dompdf from 3.0.1 to 3.0.2
Bumps [dompdf/dompdf](https://github.com/dompdf/dompdf) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/dompdf/dompdf/releases)
- [Commits](https://github.com/dompdf/dompdf/compare/v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: dompdf/dompdf
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-01 11:43:38 +00:00
dependabot[bot] ecd6b587e9 Bump tecnickcom/tcpdf from 6.7.7 to 6.8.0
Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.7.7 to 6.8.0.
- [Changelog](https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT)
- [Commits](https://github.com/tecnickcom/TCPDF/compare/6.7.7...6.8.0)

---
updated-dependencies:
- dependency-name: tecnickcom/tcpdf
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-27 19:58:22 +00:00
oleibman 1c12d32bb5 Merge branch 'master' into dompdf84b 2024-12-07 21:14:48 -08:00
oleibman 94df5941c5 Upgrade Dompdf to 8.4-Compatible Version 2024-12-07 21:09:04 -08:00
oleibman 4357263e9d Upgrade php-cs-fixer
Dependabot push required a very minor code change.
2024-12-01 06:04:52 -08:00
oleibman 41d6f5af03 Merge pull request #4253 from PHPOffice/dependabot/composer/squizlabs/php_codesniffer-3.11.1
Bump squizlabs/php_codesniffer from 3.10.3 to 3.11.1
2024-12-01 12:37:22 +00:00
oleibman b0f5e641af Merge pull request #4254 from PHPOffice/dependabot/composer/mitoteam/jpgraph-10.4.3
Bump mitoteam/jpgraph from 10.4.1 to 10.4.3
2024-12-01 12:36:54 +00:00
dependabot[bot] c9d62867c7 Bump mpdf/mpdf from 8.2.4 to 8.2.5
Bumps [mpdf/mpdf](https://github.com/mpdf/mpdf) from 8.2.4 to 8.2.5.
- [Release notes](https://github.com/mpdf/mpdf/releases)
- [Changelog](https://github.com/mpdf/mpdf/blob/development/CHANGELOG.md)
- [Commits](https://github.com/mpdf/mpdf/compare/v8.2.4...v8.2.5)

---
updated-dependencies:
- dependency-name: mpdf/mpdf
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-01 11:53:48 +00:00
dependabot[bot] 00b2ae5e4c Bump mitoteam/jpgraph from 10.4.1 to 10.4.3
Bumps [mitoteam/jpgraph](https://github.com/mitoteam/jpgraph) from 10.4.1 to 10.4.3.
- [Release notes](https://github.com/mitoteam/jpgraph/releases)
- [Commits](https://github.com/mitoteam/jpgraph/compare/10.4.1...10.4.3)

---
updated-dependencies:
- dependency-name: mitoteam/jpgraph
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-01 11:53:44 +00:00
dependabot[bot] bfd2fe72d8 Bump squizlabs/php_codesniffer from 3.10.3 to 3.11.1
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.10.3 to 3.11.1.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.10.3...3.11.1)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-01 11:53:39 +00:00
oleibman c01b94b242 Merge pull request #4232 from oleibman/upgrdunit
Upgrade PhpUnit
2024-11-14 22:47:38 +00:00
oleibman 9398f74187 Upgrade PhpUnit
To a version that knows Php8.4 deprecates E_STRICT.
2024-11-14 14:42:10 -08:00
oleibman 1419febbba Catch Phpstan Up
Its last few updates have been irksome. I need to eliminate more of the new problems with annotations rather than code because I can't figure out what it's objecting to. Nevertheless, it provides a very valuable service, so ...

Its latest release is flagging calling abs with a string, even when the string is defined as numeric-string in a doc block. Php generally allows it, though not with strict types. Changed to add 0 in those situations.
2024-11-12 06:53:22 -08:00
dependabot[bot] d780b1b1de Bump symfony/process from 6.4.8 to 6.4.14
Bumps [symfony/process](https://github.com/symfony/process) from 6.4.8 to 6.4.14.
- [Release notes](https://github.com/symfony/process/releases)
- [Changelog](https://github.com/symfony/process/blob/7.1/CHANGELOG.md)
- [Commits](https://github.com/symfony/process/compare/v6.4.8...v6.4.14)

---
updated-dependencies:
- dependency-name: symfony/process
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-06 18:24:02 +00:00
oleibman ce32cbab7b Merge pull request #4211 from PHPOffice/dependabot/composer/maennchen/zipstream-php-3.1.1
Bump maennchen/zipstream-php from 3.1.0 to 3.1.1
2024-11-01 13:54:47 +00:00
dependabot[bot] cba025a4a7 Bump maennchen/zipstream-php from 3.1.0 to 3.1.1
Bumps [maennchen/zipstream-php](https://github.com/maennchen/ZipStream-PHP) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/maennchen/ZipStream-PHP/releases)
- [Commits](https://github.com/maennchen/ZipStream-PHP/compare/3.1.0...3.1.1)

---
updated-dependencies:
- dependency-name: maennchen/zipstream-php
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-01 11:30:13 +00:00
dependabot[bot] d6749aea47 Bump tecnickcom/tcpdf from 6.7.5 to 6.7.7
Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.7.5 to 6.7.7.
- [Changelog](https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT)
- [Commits](https://github.com/tecnickcom/TCPDF/compare/6.7.5...6.7.7)

---
updated-dependencies:
- dependency-name: tecnickcom/tcpdf
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-01 11:30:04 +00:00
oleibman 95a83a19c5 Merge branch 'master' into stanupgrade 2024-10-06 09:50:16 -07:00
dependabot[bot] a729531c23 Bump squizlabs/php_codesniffer from 3.10.2 to 3.10.3
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.10.2 to 3.10.3.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHPCSStandards/PHP_CodeSniffer/compare/3.10.2...3.10.3)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-01 11:01:53 +00:00
oleibman b9a9d5ddff Upgrade Phpstan
A very rough month for Dependabot's attempt to upgrade Phpstan. Many changes involving regular expressions, most with non-trivial workarounds. I have also filed one bug report.
2024-09-01 16:03:36 -07:00
dependabot[bot] 94a14e6a23 Bump friendsofphp/php-cs-fixer from 3.61.1 to 3.64.0
Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.61.1 to 3.64.0.
- [Release notes](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases)
- [Changelog](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/compare/v3.61.1...v3.64.0)

---
updated-dependencies:
- dependency-name: friendsofphp/php-cs-fixer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-01 11:47:33 +00:00
oleibman bbf9d15cb2 Php-cs-fixer Enforcing New Rules
The latest release seems to not want you to give a class element both a Php type and a doc-block type. I used the "fix" operand to delete the redundant doc-block declarations, with no other changes. So there should be no change to executable code.
2024-08-01 10:54:54 -07:00
oleibman 7556b12b1b Prepare Changelog for 3.0
Also upgrade vendor modules a day ahead of Dependabot.
2024-07-30 22:22:22 -07:00
dependabot[bot] a299be3a75 Bump phpstan/phpstan from 1.11.3 to 1.11.5
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.11.3 to 1.11.5.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](https://github.com/phpstan/phpstan/compare/1.11.3...1.11.5)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-01 13:19:03 +00:00
oleibman cffcfb4a5c Merge pull request #4083 from PHPOffice/dependabot/composer/friendsofphp/php-cs-fixer-3.59.3
Bump friendsofphp/php-cs-fixer from 3.58.1 to 3.59.3
2024-07-01 13:13:12 +00:00