mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-24 10:58:32 +00:00
oleibman
68158c8120
These changes have already been implemented twice, and been regressed twice. I'll try once more (with a different approach), then give up ... As configured, Phpstan running under Php7 reports no errors. However, running under Php8, it reports 100 (!) errors. The vast majority of these are due to two reasons: - renaming parameters in Php builtin functions in preparation for named parameters. - using the new class GdImage rather than type resource as the argument type for many image-based functions. Regardless of the cause, this will be a problem sooner or later. This PR is an attempt to get ahead of that problem. For source members, it mostly adds annotations or updates doc-blocks. Only 2 members have changes to executable code, and these are very minor - BitWise and Writer/Xlsx. For test members, all baseline errors are deleted and the code is fixed. Php7 and Php8 both report no errors with this configuration.
59 lines
1.9 KiB
PHP
59 lines
1.9 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Functional;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Spreadsheet;
|
|
use PhpOffice\PhpSpreadsheet\Style\Alignment;
|
|
|
|
class CommentsTest extends AbstractFunctional
|
|
{
|
|
public function providerFormats(): array
|
|
{
|
|
return [
|
|
['Html'],
|
|
['Xlsx'],
|
|
['Ods'],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* Test load file with comment in sheet to load proper
|
|
* count of comments in correct coords.
|
|
*
|
|
* @dataProvider providerFormats
|
|
*/
|
|
public function testComments(string $format): void
|
|
{
|
|
$spreadsheet = new Spreadsheet();
|
|
|
|
$spreadsheet->getActiveSheet()->getCell('E10')->setValue('Comment');
|
|
$spreadsheet->getActiveSheet()
|
|
->getComment('E10')
|
|
->getText()
|
|
->createText('Comment to test');
|
|
|
|
$reloadedSpreadsheet = $this->writeAndReload($spreadsheet, $format);
|
|
|
|
$sheet = $reloadedSpreadsheet->getSheet(0);
|
|
$commentsLoaded = $sheet->getComments();
|
|
self::assertCount(1, $commentsLoaded);
|
|
|
|
$commentCoordinate = key($commentsLoaded);
|
|
self::assertSame('E10', $commentCoordinate);
|
|
self::assertSame('Comment', $sheet->getCell('E10')->getValue());
|
|
$comment = $commentsLoaded[$commentCoordinate];
|
|
self::assertSame('Comment to test', (string) $comment);
|
|
$commentClone = clone $comment;
|
|
self::assertEquals($comment, $commentClone);
|
|
self::assertNotSame($comment, $commentClone);
|
|
if ($format === 'Xlsx') {
|
|
self::assertEquals('feb0c24b880a8130262dadf801f85e94', $comment->getHashCode());
|
|
self::assertEquals(Alignment::HORIZONTAL_GENERAL, $comment->getAlignment());
|
|
$comment->setAlignment(Alignment::HORIZONTAL_RIGHT);
|
|
self::assertEquals(Alignment::HORIZONTAL_RIGHT, $comment->getAlignment());
|
|
}
|
|
$spreadsheet->disconnectWorksheets();
|
|
$reloadedSpreadsheet->disconnectWorksheets();
|
|
}
|
|
}
|