mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-24 23:08:19 +00:00
oleibman
cb23cca3ec
This issue arose while researching issue #1823. The issue was not a bug; it just required clarification to the author of how to use the software. But, while researching, I discovered that loading html into 2 sheets of a spreadsheet has a problem if the html title tag is the same for the 2 sheets. PhpSpreadsheet would be able to save the resulting file, but Excel would not be able to read it properly because of the duplicate title. The worksheet setTitle method allows for disambiguation is such a circumstance. The html reader passed a parameter indicating "don't disambiguate", but I can't see any harm in changing that to "disambiguate". An extremely simple fix, with tests to back it up.
122 lines
4.2 KiB
PHP
122 lines
4.2 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Reader\Html;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Reader\Exception as ReaderException;
|
|
use PhpOffice\PhpSpreadsheet\Reader\Html;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class HtmlLoadStringTest extends TestCase
|
|
{
|
|
public function testCanLoadFromString(): void
|
|
{
|
|
$html = '<table>
|
|
<tr>
|
|
<td>Hello World</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Hello<br />World</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Hello<br>World</td>
|
|
</tr>
|
|
</table>';
|
|
$spreadsheet = (new Html())->loadFromString($html);
|
|
$firstSheet = $spreadsheet->getSheet(0);
|
|
|
|
$cellStyle = $firstSheet->getStyle('A1');
|
|
self::assertFalse($cellStyle->getAlignment()->getWrapText());
|
|
|
|
$cellStyle = $firstSheet->getStyle('A2');
|
|
self::assertTrue($cellStyle->getAlignment()->getWrapText());
|
|
$cellValue = $firstSheet->getCell('A2')->getValue();
|
|
self::assertStringContainsString("\n", $cellValue);
|
|
|
|
$cellStyle = $firstSheet->getStyle('A3');
|
|
self::assertTrue($cellStyle->getAlignment()->getWrapText());
|
|
$cellValue = $firstSheet->getCell('A3')->getValue();
|
|
self::assertStringContainsString("\n", $cellValue);
|
|
}
|
|
|
|
public function testLoadInvalidString(): void
|
|
{
|
|
$this->expectException(ReaderException::class);
|
|
$html = '<table<>';
|
|
$spreadsheet = (new Html())->loadFromString($html);
|
|
$firstSheet = $spreadsheet->getSheet(0);
|
|
$cellStyle = $firstSheet->getStyle('A1');
|
|
self::assertFalse($cellStyle->getAlignment()->getWrapText());
|
|
}
|
|
|
|
public function testCanLoadFromStringIntoExistingSpreadsheet(): void
|
|
{
|
|
$html = '<table>
|
|
<tr>
|
|
<td>Hello World</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Hello<br />World</td>
|
|
</tr>
|
|
<tr>
|
|
<td>Hello<br>World</td>
|
|
</tr>
|
|
</table>';
|
|
$reader = new Html();
|
|
$spreadsheet = $reader->loadFromString($html);
|
|
$firstSheet = $spreadsheet->getSheet(0);
|
|
|
|
$cellStyle = $firstSheet->getStyle('A1');
|
|
self::assertFalse($cellStyle->getAlignment()->getWrapText());
|
|
|
|
$cellStyle = $firstSheet->getStyle('A2');
|
|
self::assertTrue($cellStyle->getAlignment()->getWrapText());
|
|
$cellValue = $firstSheet->getCell('A2')->getValue();
|
|
self::assertStringContainsString("\n", $cellValue);
|
|
|
|
$cellStyle = $firstSheet->getStyle('A3');
|
|
self::assertTrue($cellStyle->getAlignment()->getWrapText());
|
|
$cellValue = $firstSheet->getCell('A3')->getValue();
|
|
self::assertStringContainsString("\n", $cellValue);
|
|
|
|
$reader->setSheetIndex(1);
|
|
$html = '<table>
|
|
<tr>
|
|
<td>Goodbye World</td>
|
|
</tr>
|
|
</table>';
|
|
|
|
self::assertEquals(1, $spreadsheet->getSheetCount());
|
|
$spreadsheet = $reader->loadFromString($html, $spreadsheet);
|
|
self::assertEquals(2, $spreadsheet->getSheetCount());
|
|
}
|
|
|
|
public function testCanLoadDuplicateTitle(): void
|
|
{
|
|
$html = <<<'EOF'
|
|
<html>
|
|
<head>
|
|
<title>Sheet</title>
|
|
</head>
|
|
<body>
|
|
<table><tr><td>1</td></tr></table>
|
|
</body>
|
|
</html>
|
|
EOF;
|
|
$reader = new \PhpOffice\PhpSpreadsheet\Reader\Html();
|
|
$spreadsheet = $reader->loadFromString($html);
|
|
$reader->setSheetIndex(1);
|
|
$reader->loadFromString($html, $spreadsheet);
|
|
$reader->setSheetIndex(2);
|
|
$reader->loadFromString($html, $spreadsheet);
|
|
$sheet = $spreadsheet->getSheet(0);
|
|
self::assertEquals(1, $sheet->getCell('A1')->getValue());
|
|
self::assertEquals('Sheet', $sheet->getTitle());
|
|
$sheet = $spreadsheet->getSheet(1);
|
|
self::assertEquals(1, $sheet->getCell('A1')->getValue());
|
|
self::assertEquals('Sheet 1', $sheet->getTitle());
|
|
$sheet = $spreadsheet->getSheet(2);
|
|
self::assertEquals(1, $sheet->getCell('A1')->getValue());
|
|
self::assertEquals('Sheet 2', $sheet->getTitle());
|
|
}
|
|
}
|