mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-03 05:57:46 +00:00
oleibman
70b4ecd4d3
They aren't quite interchangeable. Both are used in the test suite, with no indication of why one or the other. I think we'd be best off being consistent. Based on the names, I think `_calculateFormulaValue` was intended as a private, or at least internal, method, so favor `calculateFormula`. I do not intend to rename or re-categorize `_calculateFormulaValue`, just remove its usage when it isn't clearly warranted.
62 lines
2.0 KiB
PHP
62 lines
2.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\MathTrig;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
|
|
|
|
class LogTest extends AllSetupTeardown
|
|
{
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('providerLOG')]
|
|
public function testLOG(mixed $expectedResult, mixed $number = 'omitted', mixed $base = 'omitted'): void
|
|
{
|
|
$this->mightHaveException($expectedResult);
|
|
$sheet = $this->getSheet();
|
|
if ($number !== null) {
|
|
$sheet->getCell('A1')->setValue($number);
|
|
}
|
|
if ($base !== null) {
|
|
$sheet->getCell('A2')->setValue($base);
|
|
}
|
|
if ($number === 'omitted') {
|
|
$sheet->getCell('B1')->setValue('=LOG()');
|
|
} elseif ($base === 'omitted') {
|
|
$sheet->getCell('B1')->setValue('=LOG(A1)');
|
|
} else {
|
|
$sheet->getCell('B1')->setValue('=LOG(A1,A2)');
|
|
}
|
|
$result = $sheet->getCell('B1')->getCalculatedValue();
|
|
self::assertEqualsWithDelta($expectedResult, $result, 1E-12);
|
|
}
|
|
|
|
public static function providerLOG(): array
|
|
{
|
|
return require 'tests/data/Calculation/MathTrig/LOG.php';
|
|
}
|
|
|
|
#[\PHPUnit\Framework\Attributes\DataProvider('providerLogArray')]
|
|
public function testLogArray(array $expectedResult, string $argument1, string $argument2): void
|
|
{
|
|
$calculation = Calculation::getInstance();
|
|
|
|
$formula = "=LOG({$argument1}, {$argument2})";
|
|
$result = $calculation->calculateFormula($formula);
|
|
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-14);
|
|
}
|
|
|
|
public static function providerLogArray(): array
|
|
{
|
|
return [
|
|
'matrix' => [
|
|
[
|
|
[-0.90308998699194, 0.3701428470511, 0.0, 1.09691001300806],
|
|
[-2.07944154167984, 0.85228540189824, 0.0, 2.525728644308256],
|
|
],
|
|
'{0.125, 2.345, 1.0, 12.5}',
|
|
'{10; 2.718281828459045}',
|
|
],
|
|
];
|
|
}
|
|
}
|