mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-03 22:19:19 +00:00
oleibman
057572ee90
* Change Additional Statistical Tests to Use Spreadsheet Context With an earlier change, I made all but 18 Statistical tests run in spreadsheet context. This PR changes 12 of those 18. The remaining 6 usually return array results, so it is a tougher task to handle them. I will continue to think on it. AVERAGEIF, AVERAGEIFS, and COUNTBLANK are changed to throw an Exception when a range is specified as a literal. They previously accepted array (enclosed in braces) literals, and bumbled along till they threw an error for non-array literals. Throwing an exception appears to be analogous to how Excel operates, rather than something more friendly like a VALUE error. There may be other functions which require similar treatment. There also remains a TODO for COUNTIFS, and possibly other functions. It appears that PhpSpreadsheet counts booleans for both integer and string compares and probably shouldn't. Again, this is a problem for another day. * Scrutinizer Fix one problem. * Scrutinizer Ignores Its Own Suggested Remedy Try another approach.
53 lines
1.9 KiB
PHP
53 lines
1.9 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Statistical;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Exception as CalcException;
|
|
|
|
class AverageIfsTest extends AllSetupTeardown
|
|
{
|
|
/**
|
|
* @dataProvider providerAVERAGEIFS
|
|
*
|
|
* @param mixed $expectedResult
|
|
*/
|
|
public function testAVERAGEIFS($expectedResult, ...$args): void
|
|
{
|
|
$this->runTestCaseNoBracket('AVERAGEIFS', $expectedResult, ...$args);
|
|
}
|
|
|
|
public function providerAVERAGEIFS(): array
|
|
{
|
|
return require 'tests/data/Calculation/Statistical/AVERAGEIFS.php';
|
|
}
|
|
|
|
// For example, A1=75, A2=94, A3=86:
|
|
// =AVERAGEIFS(A1:A3,A1:A3,">80") gives an answer, but
|
|
// =AVERAGEIFS({75;94;86},{75;94;86},">80") does not.
|
|
public function testOutliers(): void
|
|
{
|
|
$sheet = $this->getSheet();
|
|
$this->setCell('A1', 75);
|
|
$this->setCell('A2', 94);
|
|
$this->setCell('A3', 86);
|
|
$sheet->getCell('C1')->setValue('=AVERAGEIFS(A1:A3,A1:A3,">80")');
|
|
self::assertSame(90, $sheet->getCell('C1')->getCalculatedValue(), 'first and second args are range');
|
|
$sheet->getCell('C2')->setValue('=AVERAGEIFS({75;94;86},A1:A3,">80")');
|
|
|
|
try {
|
|
$sheet->getCell('C2')->getCalculatedValue();
|
|
self::fail('Should receive exception for literal array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage(), 'first arg is array literal');
|
|
}
|
|
$sheet->getCell('C3')->setValue('=AVERAGEIFS(A1:A3,{75;94;86},">80")');
|
|
|
|
try {
|
|
$sheet->getCell('C3')->getCalculatedValue();
|
|
self::fail('Should receive exception for literal array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage(), 'second arg is array literal');
|
|
}
|
|
}
|
|
}
|