mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-03 05:57:46 +00:00
oleibman
057572ee90
* Change Additional Statistical Tests to Use Spreadsheet Context With an earlier change, I made all but 18 Statistical tests run in spreadsheet context. This PR changes 12 of those 18. The remaining 6 usually return array results, so it is a tougher task to handle them. I will continue to think on it. AVERAGEIF, AVERAGEIFS, and COUNTBLANK are changed to throw an Exception when a range is specified as a literal. They previously accepted array (enclosed in braces) literals, and bumbled along till they threw an error for non-array literals. Throwing an exception appears to be analogous to how Excel operates, rather than something more friendly like a VALUE error. There may be other functions which require similar treatment. There also remains a TODO for COUNTIFS, and possibly other functions. It appears that PhpSpreadsheet counts booleans for both integer and string compares and probably shouldn't. Again, this is a problem for another day. * Scrutinizer Fix one problem. * Scrutinizer Ignores Its Own Suggested Remedy Try another approach.
54 lines
2.0 KiB
PHP
54 lines
2.0 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Statistical;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Exception as CalcException;
|
|
|
|
class CountBlankTest extends AllSetupTeardown
|
|
{
|
|
/**
|
|
* @dataProvider providerCOUNTBLANK
|
|
*
|
|
* @param mixed $expectedResult
|
|
*/
|
|
public function testCOUNTBLANK($expectedResult, ...$args): void
|
|
{
|
|
$this->runTestCaseNoBracket('COUNTBLANK', $expectedResult, ...$args);
|
|
}
|
|
|
|
public function providerCOUNTBLANK(): array
|
|
{
|
|
return require 'tests/data/Calculation/Statistical/COUNTBLANK.php';
|
|
}
|
|
|
|
public function testOutliers(): void
|
|
{
|
|
$sheet = $this->getSheet();
|
|
$sheet->getCell('C1')->setValue(1);
|
|
$sheet->getCell('C2')->setValue(2);
|
|
$sheet->getCell('C4')->setValue(4);
|
|
$sheet->getCell('A1')->setValue('=COUNTBLANK(5)');
|
|
|
|
try {
|
|
$sheet->getCell('A1')->getCalculatedValue();
|
|
self::fail('Should receive exception for non-array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage());
|
|
}
|
|
$sheet->getCell('A2')->setValue('=COUNTBLANK({1;2;4})');
|
|
|
|
try {
|
|
$sheet->getCell('A1')->getCalculatedValue();
|
|
self::fail('Should receive exception for inline array arg');
|
|
} catch (CalcException $e) {
|
|
self::assertStringContainsString('Must specify range of cells', $e->getMessage());
|
|
}
|
|
$sheet->getCell('A3')->setValue('=COUNTBLANK(C1)');
|
|
self::assertSame(0, $sheet->getCell('A3')->getCalculatedValue(), 'arg is single non-blank cell');
|
|
$sheet->getCell('A4')->setValue('=COUNTBLANK(D2)');
|
|
self::assertSame(1, $sheet->getCell('A4')->getCalculatedValue(), 'arg is single null cell');
|
|
$sheet->getCell('A5')->setValue('=COUNTBLANK(D3:D4)');
|
|
self::assertSame(2, $sheet->getCell('A5')->getCalculatedValue(), 'arg is two cells both null');
|
|
}
|
|
}
|