mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-10 10:06:30 +00:00
oleibman
1cdc6cd2fb
* Breaking Change to toFormattedString and 3 toArray Methods DocBlock says `toFormattedString` returns string, but code can return int, float, bool, null, or RichText. I think the DocBlock is correct (function name clearly indicates "to string"), and the code needs to change to match it. This is not that big a deal on its own. However, some methods in `Worksheet` call this function by default - `rangeToArray`, `toArray`, and `namedRangeToArray`. All 3 can be called with a parameter so that they don't call `toFormattedString`, but, by default, they do call, and so are affected by this change. Some unit test results are changed as a result of this code change. In all those cases, an additional test is added which would match the previous result. * Update Change Log I often skip this till later, but, since it's a breaking change ... * Scrutinizer, Plus Strange Cast to -0 Avoid Scrutinizer complaint by casting string to float, but ... Php decides resulted should sometimes be `-0`? That caused test failures. Very odd.
46 lines
1.8 KiB
PHP
46 lines
1.8 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Reader\Xls;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Reader\Xls;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class HiddenMergeCellsTest extends TestCase
|
|
{
|
|
private const FILENAME = 'tests/data/Reader/XLS/HiddenMergeCellsTest.xls';
|
|
|
|
public function testHiddenMergeCells(): void
|
|
{
|
|
$reader = new Xls();
|
|
$spreadsheet = $reader->load(self::FILENAME);
|
|
$c2InMergeRange = $spreadsheet->getActiveSheet()->getCell('C2')->isInMergeRange();
|
|
self::assertTrue($c2InMergeRange);
|
|
$a2InMergeRange = $spreadsheet->getActiveSheet()->getCell('A2')->isInMergeRange();
|
|
self::assertTrue($a2InMergeRange);
|
|
$a2MergeRangeValue = $spreadsheet->getActiveSheet()->getCell('A2')->isMergeRangeValueCell();
|
|
self::assertTrue($a2MergeRangeValue);
|
|
|
|
$cellArray = $spreadsheet->getActiveSheet()->rangeToArray('A2:C2');
|
|
self::assertSame([['12', '4', '3']], $cellArray);
|
|
$cellArray = $spreadsheet->getActiveSheet()->rangeToArray('A2:C2', null, true, false);
|
|
self::assertSame([[12, 4, 3]], $cellArray);
|
|
$spreadsheet->disconnectWorksheets();
|
|
}
|
|
|
|
public function testUnmergeHiddenMergeCells(): void
|
|
{
|
|
$reader = new Xls();
|
|
$spreadsheet = $reader->load(self::FILENAME);
|
|
$spreadsheet->getActiveSheet()->unmergeCells('A2:C2');
|
|
|
|
$c2InMergeRange = $spreadsheet->getActiveSheet()->getCell('C2')->isInMergeRange();
|
|
self::assertFalse($c2InMergeRange);
|
|
$a2InMergeRange = $spreadsheet->getActiveSheet()->getCell('A2')->isInMergeRange();
|
|
self::assertFalse($a2InMergeRange);
|
|
|
|
$cellArray = $spreadsheet->getActiveSheet()->rangeToArray('A2:C2', null, false, false, false);
|
|
self::assertSame([[12, '=6-B1', '=A2/B2']], $cellArray);
|
|
$spreadsheet->disconnectWorksheets();
|
|
}
|
|
}
|