mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-21 19:33:41 +00:00
oleibman
97aa5260d4
Continuing the work of PR #4810 and PR #4813. All "real" borders are implemented. Pseudo-borders (outline, vertical, horizontal, inside, and allBorders) are not because I'm not really sure how, or even if, Ods handles them. However, Sample20_Read_Ods demonstrates a way to emulate `outline` using just the real borders. In template OOCalcTest.ods cells B18:C19 are merged, and the merged cell has multi-colored borders, something which `outline` isn't able to do. Ods Reader handles this by assigning the border style first to cell B18 (which is what Ods wants, and it doesn't hurt Xlsx/Xls) and then to cells B18:C19 (which is what Xlsx and Xls want, and it doesn't hurt Ods). Ods Reader changes still to come - Style applied to entire row - Style applied to entire column - Parent styles? Ods Writer changes still to come - Style applied to entire row - Style applied to entire column - Parent styles? Not currently on my to-do list - Pseudo-borders - Subscript and superscript fonts (these really only make sense for RichText, and I'm not sure how Ods handles RichText) - Default border, alignment, and protection. I'm not convinced there's a use case. Ods handles its defaults in two different manners, and I don't want to spend the time trying to understand it without justification.