mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-27 10:30:02 +00:00
d27b6a672a
Scrutinizer had previously suggested annotations for 3 LookupRef tests, but it no longer accepts its own annotation for those cases. This PR cleans them up. ColumnsTest and RowsTest are extremely straightforward. IndexTest is a bit more complicated, but only because, unlike the other two, it had no test which executed in the context of a spreadsheet. And, when I added those, I discovered a couple of bugs. INDEX always requires at least 2 parameters (row# is always required), but its entry in the function table specified 1-4 parameters, now changed to 2-4. And, omitting col# is not handled the same way as specifying 0 for col#, though the code had treated them identically. (The same would have been true for row# but, because it is now required, ...)
58 lines
1.4 KiB
PHP
58 lines
1.4 KiB
PHP
<?php
|
|
|
|
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\LookupRef;
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
|
|
use PhpOffice\PhpSpreadsheet\Calculation\LookupRef;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class ColumnsTest extends TestCase
|
|
{
|
|
/**
|
|
* @dataProvider providerCOLUMNS
|
|
*
|
|
* @param mixed $expectedResult
|
|
* @param null|array|string $arg
|
|
*/
|
|
public function testCOLUMNS($expectedResult, $arg): void
|
|
{
|
|
$result = LookupRef::COLUMNS($arg);
|
|
self::assertEquals($expectedResult, $result);
|
|
}
|
|
|
|
public function providerCOLUMNS(): array
|
|
{
|
|
return require 'tests/data/Calculation/LookupRef/COLUMNS.php';
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providerColumnsArray
|
|
*/
|
|
public function testColumnsArray(int $expectedResult, string $argument): void
|
|
{
|
|
$calculation = Calculation::getInstance();
|
|
|
|
$formula = "=COLUMNS({$argument})";
|
|
$result = $calculation->_calculateFormulaValue($formula);
|
|
self::assertEquals($expectedResult, $result);
|
|
}
|
|
|
|
public function providerColumnsArray(): array
|
|
{
|
|
return [
|
|
[
|
|
3,
|
|
'{1,2,3;4,5,6}',
|
|
],
|
|
[
|
|
5,
|
|
'{1,2,3,4,5}',
|
|
],
|
|
[
|
|
1,
|
|
'{1;2;3;4;5}',
|
|
],
|
|
];
|
|
}
|
|
}
|