mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-09-25 01:31:26 +00:00
Nebojša Zlatanović
adde74b4e6
The initial fix only converted column indices to 0-based, but overlooked that row indices also need the same treatment per BIFF8 specification. Changes: - Convert firstRowIndex from 1-based to 0-based (subtract 1) - Convert lastRowIndex from 1-based to 0-based (subtract 1) - Update row capping logic for 65536 limit - Fix test assertions to expect rwMic=0 and rwMac=5 (not 1 and 6) - Enhanced documentation to clarify all DIMENSIONS indices are 0-based This now matches the behavior observed in Excel-generated XLS files, where a file with 3 rows × 5 columns shows: rwMic=0, rwMac=3, colMic=0, colMac=5 All tests pass (53 tests, 244 assertions).