mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-24 17:28:15 +00:00
oleibman
58c6e51992
* Sync composer.lock/.json and Phpstan Upgrade For some reason, a version newly cloned from master receives a complaint from composer that the lock and json files aren't in sync. So I ran composer update. The only thing that needs special attention is, as usual, Phpstan. There are an unusually large number of new differences when Phpstan is run with Php7.4 vs Php8.1. These are handled easily enough. But Reader/Xlsx seems very fragile; a change which would have eliminated one of the new errors seems to have caused Phpstan to go into a loop, as does an annotation without a code change, and, indeed, as does just about any change to that member. This bears watching, and it's a reason I will delay installing this. * Deleting Phpstan Cache Helps It lets me change Reader/Xlsx as I wished. Not a great resolution, but probably good enough. I will continue to think about it for a couple of days. * Minor DocBlock Changes Correct some PhpDocumentor problems.
92 lines
4.3 KiB
PHP
92 lines
4.3 KiB
PHP
<?php
|
|
|
|
$config = [];
|
|
|
|
if (PHP_VERSION_ID < 80000) {
|
|
// GdImage not available before PHP8
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Method .* has invalid return type GdImage\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Shared/Drawing.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Property .* has unknown class GdImage as its type\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Method .* has invalid return type GdImage\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Parameter .* of method .* has invalid type GdImage\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Worksheet/MemoryDrawing.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Class GdImage not found\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Writer/Xls/Worksheet.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~^Parameter .* of method .* has invalid type GdImage\.$~',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Writer/Xls/Worksheet.php',
|
|
'count' => 1,
|
|
];
|
|
// GdImage with Phpstan 1.9.2
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '~Class GdImage not found.*$~',
|
|
'path' => __DIR__ . '/tests/PhpSpreadsheetTests/Worksheet/MemoryDrawingTest.php',
|
|
'count' => 3,
|
|
];
|
|
// Erroneous analysis by Phpstan before PHP8 - 3rd parameter is nullable
|
|
// Fixed for Php7 with Phpstan 1.9.
|
|
//$config['parameters']['ignoreErrors'][] = [
|
|
// 'message' => '#^Parameter \\#3 \\$namespace of method XMLWriter\\:\\:startElementNs\\(\\) expects string, null given\\.$#',
|
|
// 'path' => __DIR__ . '/src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php',
|
|
// 'count' => 8,
|
|
//];
|
|
// Erroneous analysis by Phpstan before PHP8 - mb_strlen does not return false
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Method PhpOffice\\\\PhpSpreadsheet\\\\Shared\\\\StringHelper\\:\\:countCharacters\\(\\) should return int but returns int(<0, max>)?\\|false\\.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Shared/StringHelper.php',
|
|
'count' => 1,
|
|
];
|
|
// New with Phpstan 1.9.2 for Php7 only
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Parameter \\#2 \\.\\.\\.\\$args of function array_merge expects array, array<int, mixed>\\|false given.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/LookupRef/Sort.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Parameter \\#1 \\$input of function array_chunk expects array, array<int, float\\|int>\\|false given.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/MathTrig/MatrixFunctions.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Parameter \\#2 \\$array of function array_map expects array, array<int, float|int>\\|false given.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/MathTrig/Random.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Parameter \\#2 \\.\\.\\.\\$args of function array_merge expects array, array<int, mixed>\\|false given.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/TextData/Text.php',
|
|
'count' => 1,
|
|
];
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Property PhpOffice\\PhpSpreadsheet\\Shared\\JAMA\\Matrix::$A (array) does not accept array<int, array<int, int>|false>|false.$#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Shared/JAMA/Matrix.php',
|
|
'count' => 2,
|
|
];
|
|
} else {
|
|
// Flagged in Php8+ - unsure how to correct code
|
|
$config['parameters']['ignoreErrors'][] = [
|
|
'message' => '#^Binary operation "/" between float and array[|]float[|]int[|]string results in an error.#',
|
|
'path' => __DIR__ . '/src/PhpSpreadsheet/Calculation/MathTrig/Combinations.php',
|
|
'count' => 2,
|
|
];
|
|
}
|
|
|
|
return $config;
|