mirror of
https://github.com/PHPOffice/PhpSpreadsheet.git
synced 2026-08-22 13:35:59 +00:00
oleibman
f8f78a7ed3
Fix #4600. String incrementation through the `++` operator is deprecated in Php 8.5. Because we make use of that operator to iterate through columns, we are particularly hard hit by that change - unaddressed, it causes over 2,000 errors in our test suite! It is, fortunately, not as difficult as I feared to correct. Replacing the `++` operator with a call to new method `StringHelper::stringIncrement` in 79 statements scattered over 31 source modules (in src, samples, test, and infra) eliminates all the messages in the test suite. It is possible that others are lurking, but I don't know a systematic way of determining if there are others. We'll stick with this for now, and deal with any others as they show up. This PR will be applied to the master, release390, and release222 branches. It will not be applied to the release210 or release1291 branches, which will now accept security changes only.
39 lines
1.2 KiB
PHP
39 lines
1.2 KiB
PHP
<?php
|
|
|
|
use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
|
|
use PhpOffice\PhpSpreadsheet\Shared\StringHelper;
|
|
use PhpOffice\PhpSpreadsheet\Spreadsheet;
|
|
|
|
require __DIR__ . '/../Header.php';
|
|
/** @var PhpOffice\PhpSpreadsheet\Helper\Sample $helper */
|
|
|
|
// Create new Spreadsheet object
|
|
$helper->log('Create new Spreadsheet object');
|
|
$spreadsheet = new Spreadsheet();
|
|
|
|
// Add some data, we will use some formulas here
|
|
$helper->log('Add some data and formulas');
|
|
$spreadsheet->getActiveSheet()->setCellValue('A1', '=B1')
|
|
->setCellValue('A2', '=B2+1')
|
|
->setCellValue('B1', '=A1+1')
|
|
->setCellValue('B2', '=A2');
|
|
|
|
Calculation::getInstance($spreadsheet)->cyclicFormulaCount = 15;
|
|
|
|
// Calculated data
|
|
$helper->log('Calculated data');
|
|
for ($row = 1; $row <= 2; ++$row) {
|
|
for ($col = 'A'; $col != 'C'; StringHelper::stringIncrement($col)) {
|
|
$formula = $spreadsheet->getActiveSheet()->getCell($col . $row)->getValue();
|
|
if (
|
|
is_string($formula)
|
|
&& ($formula[0] == '=')
|
|
) {
|
|
$helper->log('Value of ' . $col . $row . ' [' . $formula . ']: ' . $spreadsheet->getActiveSheet()->getCell($col . $row)->getCalculatedValueString());
|
|
}
|
|
}
|
|
}
|
|
|
|
// Save
|
|
$helper->write($spreadsheet, __FILE__);
|