PhpSpreadsheet

mirror of https://github.com/PHPOffice/PhpSpreadsheet.git synced 2026-08-27 10:30:02 +00:00

Files

T

MarkBaker a91dd60a98 Refactor unit tests to ensure that assertions are in the actual test, and not in an abstract class; and that setup/teardown are in the test and not an abstract. This means that assertions and setup/teardown are always in the file when reviewing PRs.

Also enforce more rigorous Excel Function implementation by testing the underlying implementation, call via the Calc Engine, and execution from in a worksheet.
Separate out unhappy path (exception) checks into a separate test, so that a single test isn't made overcomplex checking for every potentiality.

Scrutinizer may dislike variadics, for variable number of arguments of mixed type; but tough. It's 100% valid PHP, accepted by phpstan, and makes life a lot easier.

Initial work here covers all the database and datetime unit tests for Excel function implementations.

2023-03-10 04:15:12 +01:00

Calculation

Refactor unit tests to ensure that assertions are in the actual test, and not in an abstract class; and that setup/teardown are in the test and not an abstract. This means that assertions and setup/teardown are always in the file when reviewing PRs.

2023-03-10 04:15:12 +01:00

Cell

…

Features/AutoFilter/Xlsx

…

Functional/TypeAttributePreservation

…

Reader

Correct Xlsx Parsing of quotePrefix="0" (#3438 )