Files
PhpSpreadsheet/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DAverageTest.php
T
MarkBaker a91dd60a98 Refactor unit tests to ensure that assertions are in the actual test, and not in an abstract class; and that setup/teardown are in the test and not an abstract. This means that assertions and setup/teardown are always in the file when reviewing PRs.
Also enforce more rigorous Excel Function implementation by testing the underlying implementation, call via the Calc Engine, and execution from in a worksheet.
Separate out unhappy path (exception) checks into a separate test, so that a single test isn't made overcomplex checking for every potentiality.

Scrutinizer may dislike variadics, for variable number of arguments of mixed type; but tough. It's 100% valid PHP, accepted by phpstan, and makes life a lot easier.

Initial work here covers all the database and datetime unit tests for Excel function implementations.
2023-03-10 04:15:12 +01:00

124 lines
3.7 KiB
PHP

<?php
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Database;
use PhpOffice\PhpSpreadsheet\Calculation\Database\DAverage;
use PhpOffice\PhpSpreadsheet\Calculation\Information\ExcelError;
class DAverageTest extends SetupTeardownDatabases
{
/**
* @dataProvider providerDAverage
*
* @param mixed $expectedResult
* @param mixed $database
* @param mixed $field
* @param mixed $criteria
*/
public function testDirectCallToDAverage($expectedResult, $database, $field, $criteria): void
{
$result = DAverage::evaluate($database, $field, $criteria);
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
}
/**
* @dataProvider providerDAverage
*
* @param mixed $expectedResult
* @param int|string $field
*/
public function testDAverageAsWorksheetFormula($expectedResult, array $database, $field, array $criteria): void
{
$this->prepareWorksheetWithFormula('DAVERAGE', $database, $field, $criteria);
$result = $this->getSheet()->getCell(self::RESULT_CELL)->getCalculatedValue();
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
}
public function providerDAverage(): array
{
return [
[
12,
$this->database1(),
'Yield',
[
['Tree', 'Height'],
['=Apple', '>10'],
],
],
[
268333.333333333333,
$this->database2(),
'Sales',
[
['Quarter', 'Sales Rep.'],
['>1', 'Tina'],
],
],
[
372500,
$this->database2(),
'Sales',
[
['Quarter', 'Area'],
['1', 'South'],
],
],
'numeric column, in this case referring to age' => [
13,
$this->database1(),
3,
$this->database1(),
],
'null field' => [
ExcelError::VALUE(),
$this->database1(),
null,
$this->database1(),
],
'field unknown column' => [
ExcelError::VALUE(),
$this->database1(),
'xyz',
$this->database1(),
],
'multiple criteria, omit equal sign' => [
10.5,
$this->database1(),
'Yield',
[
['Tree', 'Height'],
['=Apple', '>10'],
['Pear'],
],
],
'multiple criteria for same field' => [
10,
$this->database1(),
'Yield',
[
['Tree', 'Height', 'Age', 'Height'],
['=Apple', '>10', null, '<16'],
],
],
/* Excel seems to return #NAME? when column number
is too high or too low. This makes so little sense
to me that I'm not going to bother coding that up,
content to return #VALUE! as an invalid name would */
'field column number too high' => [
ExcelError::VALUE(),
$this->database1(),
99,
$this->database1(),
],
'field column number too low' => [
ExcelError::VALUE(),
$this->database1(),
0,
$this->database1(),
],
];
}
}