Files
PhpSpreadsheet/tests/PhpSpreadsheetTests/Calculation/Functions/DateTime/DayTest.php
T
MarkBaker a91dd60a98 Refactor unit tests to ensure that assertions are in the actual test, and not in an abstract class; and that setup/teardown are in the test and not an abstract. This means that assertions and setup/teardown are always in the file when reviewing PRs.
Also enforce more rigorous Excel Function implementation by testing the underlying implementation, call via the Calc Engine, and execution from in a worksheet.
Separate out unhappy path (exception) checks into a separate test, so that a single test isn't made overcomplex checking for every potentiality.

Scrutinizer may dislike variadics, for variable number of arguments of mixed type; but tough. It's 100% valid PHP, accepted by phpstan, and makes life a lot easier.

Initial work here covers all the database and datetime unit tests for Excel function implementations.
2023-03-10 04:15:12 +01:00

169 lines
4.9 KiB
PHP

<?php
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\DateTime;
use PhpOffice\PhpSpreadsheet\Calculation\Calculation;
use PhpOffice\PhpSpreadsheet\Calculation\DateTimeExcel\DateParts;
use PhpOffice\PhpSpreadsheet\Calculation\Exception as CalculationException;
use PhpOffice\PhpSpreadsheet\Calculation\Functions;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheetTests\Calculation\Functions\FormulaArguments;
use PHPUnit\Framework\TestCase;
class DayTest extends TestCase
{
/**
* @var string
*/
private $compatibilityMode;
protected function setUp(): void
{
parent::setUp();
$this->compatibilityMode = Functions::getCompatibilityMode();
}
protected function tearDown(): void
{
parent::tearDown();
Functions::setCompatibilityMode($this->compatibilityMode);
}
/**
* @dataProvider providerDAY
*
* @param mixed $expectedResultExcel
*/
public function testDirectCallToDAY($expectedResultExcel, ...$args): void
{
$result = DateParts::day(...$args);
self::assertSame($expectedResultExcel, $result);
}
/**
* @dataProvider providerDAY
*
* @param mixed $expectedResultExcel
*/
public function testDAYAsFormula($expectedResultExcel, ...$args): void
{
$arguments = new FormulaArguments(...$args);
$calculation = Calculation::getInstance();
$formula = "=DAY({$arguments})";
$result = $calculation->_calculateFormulaValue($formula);
self::assertSame($expectedResultExcel, $result);
}
/**
* @dataProvider providerDAY
*
* @param mixed $expectedResult
*/
public function testDAYInWorksheet($expectedResult, ...$args): void
{
$arguments = new FormulaArguments(...$args);
$spreadsheet = new Spreadsheet();
$worksheet = $spreadsheet->getActiveSheet();
$argumentCells = $arguments->populateWorksheet($worksheet);
$formula = "=DAY({$argumentCells})";
$result = $worksheet->setCellValue('A1', $formula)
->getCell('A1')
->getCalculatedValue();
self::assertSame($expectedResult, $result);
}
public function providerDAY(): array
{
return require 'tests/data/Calculation/DateTime/DAY.php';
}
/**
* @dataProvider providerDAYOpenOffice
*
* @param mixed $expectedResultOpenOffice
*/
public function testDirectCallToDAYOpenOffice($expectedResultOpenOffice, ...$args): void
{
Functions::setCompatibilityMode(Functions::COMPATIBILITY_OPENOFFICE);
$result = DateParts::day(...$args);
self::assertSame($expectedResultOpenOffice, $result);
}
/**
* @dataProvider providerDAYOpenOffice
*
* @param mixed $expectedResultOpenOffice
*/
public function testDAYAsFormulaOpenOffice($expectedResultOpenOffice, ...$args): void
{
Functions::setCompatibilityMode(Functions::COMPATIBILITY_OPENOFFICE);
$arguments = new FormulaArguments(...$args);
$calculation = Calculation::getInstance();
$formula = "=DAY({$arguments})";
$result = $calculation->_calculateFormulaValue($formula);
self::assertSame($expectedResultOpenOffice, $result);
}
public function providerDAYOpenOffice(): array
{
return require 'tests/data/Calculation/DateTime/DAYOpenOffice.php';
}
/**
* @dataProvider providerUnhappyDAY
*/
public function testDAYUnhappyPath(string $expectedException, ...$args): void
{
$arguments = new FormulaArguments(...$args);
$spreadsheet = new Spreadsheet();
$worksheet = $spreadsheet->getActiveSheet();
$argumentCells = $arguments->populateWorksheet($worksheet);
$formula = "=DAY({$argumentCells})";
$this->expectException(CalculationException::class);
$this->expectExceptionMessage($expectedException);
$worksheet->setCellValue('A1', $formula)
->getCell('A1')
->getCalculatedValue();
}
public function providerUnhappyDAY(): array
{
return [
['Formula Error: Wrong number of arguments for DAY() function'],
];
}
/**
* @dataProvider providerDayArray
*/
public function testDayArray(array $expectedResult, string $array): void
{
$calculation = Calculation::getInstance();
$formula = "=DAY({$array})";
$result = $calculation->_calculateFormulaValue($formula);
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-14);
}
public function providerDayArray(): array
{
return [
'row vector' => [[[1, 12, 22]], '{"2022-01-01", "2022-06-12", "2023-07-22"}'],
'column vector' => [[[1], [3], [6]], '{"2022-01-01"; "2022-01-03"; "2022-01-06"}'],
'matrix' => [[[1, 10], [15, 31]], '{"2022-01-01", "2022-01-10"; "2022-08-15", "2022-12-31"}'],
];
}
}