Files
PhpSpreadsheet/tests/PhpSpreadsheetTests/Calculation/Functions/Database/DProductTest.php
T
MarkBaker a91dd60a98 Refactor unit tests to ensure that assertions are in the actual test, and not in an abstract class; and that setup/teardown are in the test and not an abstract. This means that assertions and setup/teardown are always in the file when reviewing PRs.
Also enforce more rigorous Excel Function implementation by testing the underlying implementation, call via the Calc Engine, and execution from in a worksheet.
Separate out unhappy path (exception) checks into a separate test, so that a single test isn't made overcomplex checking for every potentiality.

Scrutinizer may dislike variadics, for variable number of arguments of mixed type; but tough. It's 100% valid PHP, accepted by phpstan, and makes life a lot easier.

Initial work here covers all the database and datetime unit tests for Excel function implementations.
2023-03-10 04:15:12 +01:00

100 lines
3.3 KiB
PHP

<?php
namespace PhpOffice\PhpSpreadsheetTests\Calculation\Functions\Database;
use PhpOffice\PhpSpreadsheet\Calculation\Database\DProduct;
use PhpOffice\PhpSpreadsheet\Calculation\DateTimeExcel\Helpers as DateTimeHelper;
use PhpOffice\PhpSpreadsheet\Calculation\Information\ExcelError;
class DProductTest extends SetupTeardownDatabases
{
/**
* @dataProvider providerDProduct
*
* @param mixed $expectedResult
* @param mixed $database
* @param mixed $field
* @param mixed $criteria
*/
public function testDirectCallToDProduct($expectedResult, $database, $field, $criteria): void
{
$result = DProduct::evaluate($database, $field, $criteria);
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
}
/**
* @dataProvider providerDProduct
*
* @param mixed $expectedResult
* @param mixed $database
* @param mixed $field
* @param mixed $criteria
*/
public function testDProductAsWorksheetFormula($expectedResult, $database, $field, $criteria): void
{
$this->prepareWorksheetWithFormula('DPRODUCT', $database, $field, $criteria);
$result = $this->getSheet()->getCell(self::RESULT_CELL)->getCalculatedValue();
self::assertEqualsWithDelta($expectedResult, $result, 1.0e-12);
}
private function database5(): array
{
return [
['Name', 'Date', 'Test', 'Score'],
['Gary', DateTimeHelper::getDateValue('01-Jan-2017'), 'Test1', 4],
['Gary', DateTimeHelper::getDateValue('01-Jan-2017'), 'Test2', 4],
['Gary', DateTimeHelper::getDateValue('01-Jan-2017'), 'Test3', 3],
['Gary', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test1', 3],
['Gary', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test2', 4],
['Gary', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test3', 3],
['Kev', DateTimeHelper::getDateValue('02-Jan-2017'), 'Test1', 2],
['Kev', DateTimeHelper::getDateValue('02-Jan-2017'), 'Test2', 3],
['Kev', DateTimeHelper::getDateValue('02-Jan-2017'), 'Test3', 5],
['Kev', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test1', 3],
['Kev', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test2', 2],
['Kev', DateTimeHelper::getDateValue('05-Jan-2017'), 'Test3', 5],
];
}
public function providerDProduct(): array
{
return [
[
800.0,
$this->database1(),
'Yield',
[
['Tree', 'Height', 'Height'],
['=Apple', '>10', '<16'],
['=Pear', null, null],
],
],
[
36.0,
$this->database5(),
'Score',
[
['Name', 'Date'],
['Gary', '05-Jan-2017'],
],
],
[
8.0,
$this->database5(),
'Score',
[
['Test', 'Date'],
['Test1', '<05-Jan-2017'],
],
],
'omitted field name' => [
ExcelError::VALUE(),
$this->database1(),
null,
$this->database1(),
],
];
}
}