From 3523d34b50c97bf28f924ebef684aea4052a94fe Mon Sep 17 00:00:00 2001
From: Fabien Potencier <fabien@potencier.org>
Date: Sun, 29 Sep 2024 18:23:14 +0200
Subject: [PATCH] Add missing is_iterable() checks

---
 src/Extension/CoreExtension.php | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/src/Extension/CoreExtension.php b/src/Extension/CoreExtension.php
index de26ad8b4..c8e854658 100644
--- a/src/Extension/CoreExtension.php
+++ b/src/Extension/CoreExtension.php
@@ -1823,10 +1823,12 @@ final class CoreExtension extends AbstractExtension
      */
     public static function column($array, $name, $index = null): array
     {
+        if (!is_iterable($array)) {
+            throw new RuntimeError(\sprintf('The "column" filter only works with sequences/mappings or "Traversable", got "%s" as first argument.', get_debug_type($array)));
+        }
+
         if ($array instanceof \Traversable) {
             $array = iterator_to_array($array);
-        } elseif (!\is_array($array)) {
-            throw new RuntimeError(\sprintf('The "column" filter only works with sequences/mappings or "Traversable", got "%s" as first argument.', get_debug_type($array)));
         }
 
         return array_column($array, $name, $index);
@@ -1856,6 +1858,10 @@ final class CoreExtension extends AbstractExtension
      */
     public static function find(Environment $env, $array, $arrow)
     {
+        if (!is_iterable($array)) {
+            throw new RuntimeError(\sprintf('The "find" filter expects a sequence/mapping or "Traversable", got "%s".', get_debug_type($array)));
+        }
+
         self::checkArrowInSandbox($env, $arrow, 'find', 'filter');
 
         foreach ($array as $k => $v) {
@@ -1891,12 +1897,12 @@ final class CoreExtension extends AbstractExtension
      */
     public static function reduce(Environment $env, $array, $arrow, $initial = null)
     {
-        self::checkArrowInSandbox($env, $arrow, 'reduce', 'filter');
-
-        if (!\is_array($array) && !$array instanceof \Traversable) {
+        if (!is_iterable($array)) {
             throw new RuntimeError(\sprintf('The "reduce" filter only works with sequences/mappings or "Traversable", got "%s" as first argument.', get_debug_type($array)));
         }
 
+        self::checkArrowInSandbox($env, $arrow, 'reduce', 'filter');
+
         $accumulator = $initial;
         foreach ($array as $key => $value) {
             $accumulator = $arrow($accumulator, $value, $key);
@@ -1910,6 +1916,10 @@ final class CoreExtension extends AbstractExtension
      */
     public static function arraySome(Environment $env, $array, $arrow)
     {
+        if (!is_iterable($array)) {
+            throw new RuntimeError(\sprintf('The "has some" filter only works with sequences/mappings or "Traversable", got "%s" as first argument.', get_debug_type($array)));
+        }
+
         self::checkArrowInSandbox($env, $arrow, 'has some', 'operator');
 
         foreach ($array as $k => $v) {
@@ -1926,6 +1936,10 @@ final class CoreExtension extends AbstractExtension
      */
     public static function arrayEvery(Environment $env, $array, $arrow)
     {
+        if (!is_iterable($array)) {
+            throw new RuntimeError(\sprintf('The "has every" filter only works with sequences/mappings or "Traversable", got "%s" as first argument.', get_debug_type($array)));
+        }
+
         self::checkArrowInSandbox($env, $arrow, 'has every', 'operator');
 
         foreach ($array as $k => $v) {