geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-13 02:46:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removing array_shift for optimisation.

Browse Source 
For example we check if a template and use exception to redirect to a default template

Before : We checked ~1000 times => 100sec due to array_shift
After  : ~1sec
This commit is contained in:
Joel Wurtz
2011-08-30 06:02:31 +03:00
parent 543d18b27d
commit 4dc490fbd5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Twig/Error.php
+4 -1
View File
@@ -175,7 +175,10 @@ class Twig_Error extends Exception
$tokens = token_get_all(file_get_contents($r->getFilename())); $tokens = token_get_all(file_get_contents($r->getFilename()));
$templateline = -1; $templateline = -1;
$template = null; $template = null;
while ($token = array_shift($tokens)) { $tokensSize = count($tokens);
for($j = 0; $j < $tokensSize; $j++) {
$token = $tokens[$j];
if (isset($token[2]) && $token[2] >= $line) { if (isset($token[2]) && $token[2] >= $line) {
return array($templateline, $template); return array($templateline, $template);
} }