From 53a3ccd2d2afa6b4c4719aff97a9531e3446cc43 Mon Sep 17 00:00:00 2001 From: Harry Bournis Date: Tue, 3 Nov 2020 19:21:08 +0200 Subject: [PATCH] Fix `odd` not working for negative numbers --- doc/advanced.rst | 2 +- src/Node/Expression/Test/OddTest.php | 2 +- tests/Fixtures/tests/odd.test | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/advanced.rst b/doc/advanced.rst index f1ac102b5..71f71fec1 100644 --- a/doc/advanced.rst +++ b/doc/advanced.rst @@ -359,7 +359,7 @@ This is used by many of the tests built into Twig:: $compiler ->raw('(') ->subcompile($this->getNode('node')) - ->raw(' % 2 == 1') + ->raw(' % 2 != 0') ->raw(')') ; } diff --git a/src/Node/Expression/Test/OddTest.php b/src/Node/Expression/Test/OddTest.php index 2dc693a9a..189e51e76 100644 --- a/src/Node/Expression/Test/OddTest.php +++ b/src/Node/Expression/Test/OddTest.php @@ -28,7 +28,7 @@ class OddTest extends TestExpression $compiler ->raw('(') ->subcompile($this->getNode('node')) - ->raw(' % 2 == 1') + ->raw(' % 2 != 0') ->raw(')') ; } diff --git a/tests/Fixtures/tests/odd.test b/tests/Fixtures/tests/odd.test index ec88bb519..1717ef894 100644 --- a/tests/Fixtures/tests/odd.test +++ b/tests/Fixtures/tests/odd.test @@ -3,8 +3,10 @@ --TEMPLATE-- {{ 1 is odd ? 'ok' : 'ko' }} {{ 2 is odd ? 'ko' : 'ok' }} +{{ -1 is odd ? 'ok' : 'ko' }} --DATA-- return [] --EXPECT-- ok +ok ok \ No newline at end of file