geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-07 16:06:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rely on reflection to access null properties

Browse Source
This commit is contained in:
Nicolas Grekas
2024-10-29 17:41:50 +01:00
parent d72ae2447e
commit 5cd1ff1977
1 changed files with 45 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Extension/CoreExtension.php
+45 -6
View File
@@ -1642,7 +1642,7 @@ final class CoreExtension extends AbstractExtension
// array
if (Template::METHOD_CALL !== $type) {
$arrayItem = \is_bool($item) || \is_float($item) ? (int) $item : $item;
$arrayItem = \is_bool($item) || \is_float($item) ? (int) $item : $item = (string) $item;
if ($sandboxed && $object instanceof \ArrayAccess && !\in_array($object::class, self::ARRAY_LIKE_CLASSES, true)) {
try {
@@ -1652,9 +1652,11 @@ final class CoreExtension extends AbstractExtension
}
}
if (((\is_array($object) || $object instanceof \ArrayObject) && (isset($object[$arrayItem]) || \array_key_exists($arrayItem, (array) $object)))
|| ($object instanceof \ArrayAccess && isset($object[$arrayItem]))
) {
if (match (true) {
\is_array($object) => \array_key_exists($arrayItem, $object),
$object instanceof \ArrayAccess => $object->offsetExists($arrayItem),
default => false,
}) {
if ($isDefinedTest) {
return true;
}
@@ -1697,6 +1699,8 @@ final class CoreExtension extends AbstractExtension
}
}
$item = (string) $item;
if (!\is_object($object)) {
if ($isDefinedTest) {
return false;
@@ -1731,12 +1735,24 @@ final class CoreExtension extends AbstractExtension
}
}
if (isset($object->$item) || \array_key_exists((string) $item, (array) $object)) {
static $propertyCheckers = [];
if (isset($object->$item)
|| ($propertyCheckers[$object::class][$item] ??= self::getPropertyChecker($object::class, $item))($object, $item)
) {
if ($isDefinedTest) {
return true;
}
return isset($object->$item) ? $object->$item : ((array) $object)[(string) $item];
return $object->$item;
}
if ($object instanceof \DateTimeInterface && \in_array($item, ['date', 'timezone', 'timezone_type'], true)) {
if ($isDefinedTest) {
return true;
}
return ((array) $object)[$item];
}
if (\defined($object::class.'::'.$item)) {
@@ -2099,4 +2115,27 @@ final class CoreExtension extends AbstractExtension
return new GetAttrExpression($args[0], $args[1], $args[2] ?? null, Template::ANY_CALL, $line);
}
private static function getPropertyChecker(string $class, string $property): \Closure
{
static $classReflectors = [];
$class = $classReflectors[$class] ??= new \ReflectionClass($class);
if (!$class->hasProperty($property)) {
static $propertyExists;
return $propertyExists ??= \Closure::fromCallable('property_exists');
}
$property = $class->getProperty($property);
if (!$property->isPublic()) {
static $false;
return $false ??= static fn () => false;
}
return static fn ($object) => $property->isInitialized($object);
}
}