geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-12 18:36:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark new SourcePolicyInterface column filter tests as @group legacy

Browse Source 
These tests pass a SourcePolicyInterface instance to SandboxExtension, which
triggers the 3.27 deprecation. Mark them legacy and assert the deprecation
to silence the PHPUnit "unhandled deprecation" report.
This commit is contained in:
Fabien Potencier
2026-05-24 11:16:20 +02:00
parent 09c6706407
commit afbaa2a9da
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/Extension/SandboxTest.php
+20
View File
@@ -1173,8 +1173,13 @@ EOF
$this->assertSame('bar', $twig->load('index')->render($params)); $this->assertSame('bar', $twig->load('index')->render($params));
} }
/**
* @group legacy
*/
public function testSourcePolicySandboxBlocksColumnFilterOnDisallowedProperty() public function testSourcePolicySandboxBlocksColumnFilterOnDisallowedProperty()
{ {
$this->expectDeprecation('Since twig/twig 3.27.0: The "Twig\Sandbox\SourcePolicyInterface" interface is deprecated with no replacement, do not pass an instance to "Twig\Extension\SandboxExtension".');
$sourcePolicy = new class implements SourcePolicyInterface { $sourcePolicy = new class implements SourcePolicyInterface {
public function enableSandbox(Source $source): bool public function enableSandbox(Source $source): bool
{ {
@@ -1194,8 +1199,13 @@ EOF
} }
} }
/**
* @group legacy
*/
public function testSourcePolicySandboxBlocksColumnFilterOnDisallowedIndex() public function testSourcePolicySandboxBlocksColumnFilterOnDisallowedIndex()
{ {
$this->expectDeprecation('Since twig/twig 3.27.0: The "Twig\Sandbox\SourcePolicyInterface" interface is deprecated with no replacement, do not pass an instance to "Twig\Extension\SandboxExtension".');
$sourcePolicy = new class implements SourcePolicyInterface { $sourcePolicy = new class implements SourcePolicyInterface {
public function enableSandbox(Source $source): bool public function enableSandbox(Source $source): bool
{ {
@@ -1215,8 +1225,13 @@ EOF
} }
} }
/**
* @group legacy
*/
public function testSourcePolicySandboxAllowsColumnFilterOnAllowedProperty() public function testSourcePolicySandboxAllowsColumnFilterOnAllowedProperty()
{ {
$this->expectDeprecation('Since twig/twig 3.27.0: The "Twig\Sandbox\SourcePolicyInterface" interface is deprecated with no replacement, do not pass an instance to "Twig\Extension\SandboxExtension".');
$sourcePolicy = new class implements SourcePolicyInterface { $sourcePolicy = new class implements SourcePolicyInterface {
public function enableSandbox(Source $source): bool public function enableSandbox(Source $source): bool
{ {
@@ -1230,8 +1245,13 @@ EOF
$this->assertSame('bar', $twig->load('index')->render($params)); $this->assertSame('bar', $twig->load('index')->render($params));
} }
/**
* @group legacy
*/
public function testSourcePolicySandboxBlocksColumnFilterOnMagicGetter() public function testSourcePolicySandboxBlocksColumnFilterOnMagicGetter()
{ {
$this->expectDeprecation('Since twig/twig 3.27.0: The "Twig\Sandbox\SourcePolicyInterface" interface is deprecated with no replacement, do not pass an instance to "Twig\Extension\SandboxExtension".');
$sourcePolicy = new class implements SourcePolicyInterface { $sourcePolicy = new class implements SourcePolicyInterface {
public function enableSandbox(Source $source): bool public function enableSandbox(Source $source): bool
{ {