fix escaping strategy detection based on filename

This commit is contained in:
Tobias Schultze
2015-08-31 14:27:59 +02:00
parent 5815c8344b
commit e403363b1a
2 changed files with 16 additions and 5 deletions
+13 -4
View File
@@ -27,15 +27,21 @@ class Twig_FileExtensionEscapingStrategy
* *
* @param string $filename The template file name * @param string $filename The template file name
* *
* @return string The escaping strategy name to use * @return string|false The escaping strategy name to use or false to disable
*/ */
public static function guess($filename) public static function guess($filename)
{ {
if (!preg_match('{\.(js|css|txt)(?:\.[^/\\\\]+)?$}', $filename, $match)) { if (in_array(substr($filename, -1), array('/', '\\'))) {
return 'html'; return 'html'; // return html for directories
} }
switch ($match[1]) { if ('.twig' === substr($filename, -5)) {
$filename = substr($filename, 0, -5);
}
$extension = pathinfo($filename, PATHINFO_EXTENSION);
switch ($extension) {
case 'js': case 'js':
return 'js'; return 'js';
@@ -44,6 +50,9 @@ class Twig_FileExtensionEscapingStrategy
case 'txt': case 'txt':
return false; return false;
default:
return 'html';
} }
} }
} }
@@ -16,7 +16,7 @@ class Twig_Tests_FileExtensionEscapingStrategyTest extends PHPUnit_Framework_Tes
*/ */
public function testGuess($strategy, $filename) public function testGuess($strategy, $filename)
{ {
$this->assertEquals($strategy, Twig_FileExtensionEscapingStrategy::guess($filename)); $this->assertSame($strategy, Twig_FileExtensionEscapingStrategy::guess($filename));
} }
public function getGuessData() public function getGuessData()
@@ -34,6 +34,8 @@ class Twig_Tests_FileExtensionEscapingStrategyTest extends PHPUnit_Framework_Tes
array('css', 'foo.css'), array('css', 'foo.css'),
array('css', 'foo.css.twig'), array('css', 'foo.css.twig'),
array('css', 'foo.twig.css'), array('css', 'foo.twig.css'),
array('css', 'foo.js.css'),
array('css', 'foo.js.css.twig'),
// js // js
array('js', 'foo.js'), array('js', 'foo.js'),