geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-16 12:26:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

⚰️ Drop useless php comparisons

Browse Source
This commit is contained in:
Guillaume
2026-07-18 18:06:34 +02:00
parent d659593774
commit f2e549a92b
4 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extra/intl-extra/Tests/Fixtures/format_date_php8.test
+1 -1
View File
@@ -1,7 +1,7 @@
--TEST-- --TEST--
"format_date" filter "format_date" filter
--CONDITION-- --CONDITION--
PHP_VERSION_ID >= 80000 && version_compare(Symfony\Component\Intl\Intl::getIcuVersion(), '72.1', '<') version_compare(Symfony\Component\Intl\Intl::getIcuVersion(), '72.1', '<')
--TEMPLATE-- --TEMPLATE--
{{ 'today 23:39:12'|format_datetime('relative_short', 'none', locale='fr') }} {{ 'today 23:39:12'|format_datetime('relative_short', 'none', locale='fr') }}
{{ 'today 23:39:12'|format_datetime('relative_full', 'full', locale='fr') }} {{ 'today 23:39:12'|format_datetime('relative_full', 'full', locale='fr') }}
extra/intl-extra/Tests/Fixtures/format_date_php8_ICU72.test
+1 -1
View File
@@ -1,7 +1,7 @@
--TEST-- --TEST--
"format_date" filter "format_date" filter
--CONDITION-- --CONDITION--
PHP_VERSION_ID >= 80000 && version_compare(Symfony\Component\Intl\Intl::getIcuVersion(), '72.1', '>=') version_compare(Symfony\Component\Intl\Intl::getIcuVersion(), '72.1', '>=')
--TEMPLATE-- --TEMPLATE--
{{ 'today 23:39:12'|format_datetime('relative_short', 'none', locale='fr') }} {{ 'today 23:39:12'|format_datetime('relative_short', 'none', locale='fr') }}
{{ 'today 23:39:12'|format_datetime('relative_full', 'full', locale='fr') }} {{ 'today 23:39:12'|format_datetime('relative_full', 'full', locale='fr') }}
tests/Fixtures/functions/enum/invalid_dynamic_enum.test
-1
View File
@@ -1,7 +1,6 @@
--TEST-- --TEST--
"enum" function with invalid dynamic enum class "enum" function with invalid dynamic enum class
--CONDITION-- --CONDITION--
\PHP_VERSION_ID >= 80100
--TEMPLATE-- --TEMPLATE--
{% set from_variable = 'Twig\Tests\NonExistentEnum' %} {% set from_variable = 'Twig\Tests\NonExistentEnum' %}
{% for c in enum(from_variable).cases() %} {% for c in enum(from_variable).cases() %}
tests/Util/CallableArgumentsExtractorTest.php
-12
View File
@@ -71,18 +71,6 @@ class CallableArgumentsExtractorTest extends TestCase
$this->getArguments('date', 'date', ['Y-m-d', 'timestamp' => null, 'unknown1' => '', 'unknown2' => '']); $this->getArguments('date', 'date', ['Y-m-d', 'timestamp' => null, 'unknown1' => '', 'unknown2' => '']);
} }
public function testResolveArgumentsWithMissingValueForOptionalArgument(): void
{
if (\PHP_VERSION_ID >= 80000) {
$this->markTestSkipped('substr_compare() has a default value in 8.0, so the test does not work anymore, one should find another PHP built-in function for this test to work in PHP 8.');
}
$this->expectException(SyntaxError::class);
$this->expectExceptionMessage('Argument "case_sensitivity" could not be assigned for function "substr_compare(main_str, str, offset, length, case_sensitivity)" because it is mapped to an internal PHP function which cannot determine default value for optional argument "length".');
$this->getArguments('substr_compare', 'substr_compare', ['abcd', 'bc', 'offset' => 1, 'case_sensitivity' => true]);
}
public function testResolveArgumentsOnlyNecessaryArgumentsForCustomFunction(): void public function testResolveArgumentsOnlyNecessaryArgumentsForCustomFunction(): void
{ {
$this->assertEquals(['arg1'], $this->getArguments('custom_function', [$this, 'customFunction'], ['arg1' => 'arg1'])); $this->assertEquals(['arg1'], $this->getArguments('custom_function', [$this, 'customFunction'], ['arg1' => 'arg1']));