geckon01/Twig
1
0
Fork 0
mirror of https://github.com/twigphp/Twig.git synced 2026-09-16 20:36:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a constant for the main namespace

Browse Source
This commit is contained in:
Chris Smith
2013-06-28 10:26:16 +01:00
parent 6f0753f0ff
commit f80bab25d3
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Twig/Loader/Filesystem.php
+9 -6
View File
@@ -16,6 +16,9 @@
*/ */
class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderInterface class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderInterface
{ {
/** Identifier of the main namespace. */
const MAIN_NAMESPACE = '__main__';
protected $paths; protected $paths;
protected $cache; protected $cache;
@@ -38,7 +41,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
* *
* @return array The array of paths where to look for templates * @return array The array of paths where to look for templates
*/ */
public function getPaths($namespace = '__main__') public function getPaths($namespace = self::MAIN_NAMESPACE)
{ {
return isset($this->paths[$namespace]) ? $this->paths[$namespace] : array(); return isset($this->paths[$namespace]) ? $this->paths[$namespace] : array();
} }
@@ -46,7 +49,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
/** /**
* Returns the path namespaces. * Returns the path namespaces.
* *
* The "__main__" namespace is always defined. * The main namespace is always defined.
* *
* @return array The array of defined namespaces * @return array The array of defined namespaces
*/ */
@@ -61,7 +64,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
* @param string|array $paths A path or an array of paths where to look for templates * @param string|array $paths A path or an array of paths where to look for templates
* @param string $namespace A path namespace * @param string $namespace A path namespace
*/ */
public function setPaths($paths, $namespace = '__main__') public function setPaths($paths, $namespace = self::MAIN_NAMESPACE)
{ {
if (!is_array($paths)) { if (!is_array($paths)) {
$paths = array($paths); $paths = array($paths);
@@ -81,7 +84,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
* *
* @throws Twig_Error_Loader * @throws Twig_Error_Loader
*/ */
public function addPath($path, $namespace = '__main__') public function addPath($path, $namespace = self::MAIN_NAMESPACE)
{ {
// invalidate the cache // invalidate the cache
$this->cache = array(); $this->cache = array();
@@ -101,7 +104,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
* *
* @throws Twig_Error_Loader * @throws Twig_Error_Loader
*/ */
public function prependPath($path, $namespace = '__main__') public function prependPath($path, $namespace = self::MAIN_NAMESPACE)
{ {
// invalidate the cache // invalidate the cache
$this->cache = array(); $this->cache = array();
@@ -175,7 +178,7 @@ class Twig_Loader_Filesystem implements Twig_LoaderInterface, Twig_ExistsLoaderI
$this->validateName($name); $this->validateName($name);
$namespace = '__main__'; $namespace = self::MAIN_NAMESPACE;
if (isset($name[0]) && '@' == $name[0]) { if (isset($name[0]) && '@' == $name[0]) {
if (false === $pos = strpos($name, '/')) { if (false === $pos = strpos($name, '/')) {
throw new Twig_Error_Loader(sprintf('Malformed namespaced template name "%s" (expecting "@namespace/template_name").', $name)); throw new Twig_Error_Loader(sprintf('Malformed namespaced template name "%s" (expecting "@namespace/template_name").', $name));
test/Twig/Tests/Loader/FilesystemTest.php
+2 -2
View File
@@ -89,9 +89,9 @@ class Twig_Tests_Loader_FilesystemTest extends PHPUnit_Framework_TestCase
public function testGetNamespaces() public function testGetNamespaces()
{ {
$loader = new Twig_Loader_Filesystem(sys_get_temp_dir()); $loader = new Twig_Loader_Filesystem(sys_get_temp_dir());
$this->assertEquals(array('__main__'), $loader->getNamespaces()); $this->assertEquals(array(Twig_Loader_Filesystem::MAIN_NAMESPACE), $loader->getNamespaces());
$loader->addPath(sys_get_temp_dir(), 'named'); $loader->addPath(sys_get_temp_dir(), 'named');
$this->assertEquals(array('__main__', 'named'), $loader->getNamespaces()); $this->assertEquals(array(Twig_Loader_Filesystem::MAIN_NAMESPACE, 'named'), $loader->getNamespaces());
} }
} }