This PR was submitted for the 3.x branch but it was merged into the 2.x branch instead.
Discussion
----------
Added installation instructions
Commits
-------
4e2fd8f2 Added installation instructions
This PR was merged into the 2.x branch.
Discussion
----------
Allow installation of league/html-to-markdown 5.x
Release notes: https://github.com/thephpleague/html-to-markdown/releases/tag/5.0.0
There were no changes that would impact how this Twig Markdown Extension calls the html-to-markdown library, meaning that both 4.8+ and 5.x should be fully compatible.
Commits
-------
2c6fa023 Allow installation of league/html-to-markdown 5.x
This PR was squashed before being merged into the 1.x branch.
Discussion
----------
added PHP 8.1 as experimental
fixes#3494
Commits
-------
bef89dcc added PHP 8.1 as experimental
This PR was merged into the 2.x branch.
Discussion
----------
[Doc] Update the Twig version where spaceless filter was added
Commits
-------
e23852c8 [Doc] Update the Twig version where spaceless filter was added
This PR was merged into the 3.x branch.
Discussion
----------
Allowing compat with Twig 2 by conditionally calling method
This is an annoying, edge-case issue. The original fix was #3463. The problem, discovered by MakerBundle's tests (I'm not sure why it didn't pop up sooner) is if you're using PHP 7.1... for example with Symfony 4.4 LTS. In that situation, if you run:
```
composer require symfony/twig-pack
```
You will get:
* `twig/twig` v2 (since v3 required PHP 7.2)
* `twig/twig-extra-bundle` 3.2.0 (3.2.1 doesn't allow `twig/twig` v2, but 3.2.0 does).
The result is the container explodes:
```
!!
!! [critical] Uncaught Error: Call to undefined method Twig\Environment::registerUndefinedTokenParserCallback()
!!
!!
!! In srcApp_KernelDevDebugContainer.php line 1176:
!!
!! Attempted to call an undefined method named "registerUndefinedTokenParserCa
!! llback" of class "Twig\Environment".
!! Did you mean to call e.g. "registerUndefinedFilterCallback" or "registerUnd
!! efinedFunctionCallback"?
```
Is this worth fixing? If not, we'll need to work around in the MakerBundle tests.
Thanks!
Commits
-------
ef15dd3a Allowing compat with Twig 2 by conditionally calling method
This PR was merged into the 1.x branch.
Discussion
----------
Fix length filter doc Add some return types
These return types preemptively tell consumers that Twig 4 / PHP 9 might add real return types here.
For `Profile`, we can add the return types right away because the class is `@final`.
Spotted by DebugClassLoader comparing return types of internal PHP base types / magic methods.
Commits
-------
50d032c4 Add some return types
This PR was submitted for the 3.x branch but it was squashed and merged into the 2.x branch instead.
Discussion
----------
Add slug filter (follow-up to PR #3386)
Hi,
This is a follow-up to PR #3386, in which @seb-jean had done most of the work.
I went ahead and implemented the remaining fixes for the pending comments/reviews, and added some documentation on the filter.
Let me know if anything else should be done before this can be merged, and I will get it done ASAP.
Cheers!
Commits
-------
0fd67941 Add slug filter (follow-up to PR #3386)
This PR was merged into the 1.x branch.
Discussion
----------
Adding link to the SymfonyCasts Twig tutorial
Hi!
We have (and have had) for a long time, a really nice Twig screencast on SymfonyCasts with interactive coding challenges so people can play with Twig. I thought a link from Twig's docs might be useful :). I was also thinking a link from https://twig.symfony.com/doc/3.x/ might make sense, but I think this isn't modifiable directly via the docs (but tell me if I'm wrong).
Here's the "look":
<img width="776" alt="Screen Shot 2021-01-13 at 1 07 40 PM" src="https://user-images.githubusercontent.com/121003/104491678-93ef6480-55a0-11eb-9dce-db24c0748267.png">
Thanks!
Commits
-------
500a7da9 Adding link to the SymfonyCasts Twig tutorial
This PR was merged into the 3.x branch.
Discussion
----------
Allow macro calls and definition inside cache tag
Solve #3466
Commits
-------
0bdad6fb Allow macro calls and definition inside cache tag
Fabien Potencier
Thomas Landauer
Colin O'Dell
Oleg Andreyev
Javier Eguiluz
Ryan Weaver
Mike Zukowsky
Nicolas Grekas
Émile Perron
Christian Flothmann
Vincent Langlet
Yann ROTROU
