This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2406).
Discussion
----------
Fix tokenize call in DeprecationCollector
Hi,
if fixes `Argument 1 passed to Twig_Environment::tokenize() must be an instance of Twig_Source, string given`
Commits
-------
13ca97c1 Fix tokenize call in DeprecationCollector
* 1.x:
fixed tests for PHP 5.2
fixed tests for PHP 5.2
fixed tests for PHP 5.2
Fix typo in test filename
added a note in the docs about the PSR-11 runtime loader
fixed typo
updated CHANGELOG
bumped version to 1.32
Add ContainerRuntimeLoader
tweaked docs
Update striptags.rst
fixed CS
Mention autoescape=true deprecation (issue #2386)
Fix typo.
bumped version to 1.31.1-DEV
prepared the 1.31.0 release
added a note about macros usage in the deprecated docs
This PR was merged into the 2.x branch.
Discussion
----------
Change ~ with ^ for version in composer require
Caret symbol sticks closer to semantic versioning, and will always allow non-breaking updates
Commits
-------
8a62689d Change '~' with '^' for version in composer require
This PR was submitted for the 2.x branch but it was merged into the 1.x branch instead (closes#2371).
Discussion
----------
Update striptags.rst
Add information about supported param. Replaces #2370
Commits
-------
048f5490 Update striptags.rst
This PR was squashed before being merged into the 1.x branch (closes#2388).
Discussion
----------
Mention autoescape=true deprecation (issue #2386)
Per #2386, mention the deprecation of true in favor of an explicit "html".
Commits
-------
70d03042 Mention autoescape=true deprecation (issue #2386)
This PR was merged into the 2.x branch.
Discussion
----------
Remove legacy exception catch blocks from 2.x
These `catch` blocks were only useful for compatibility with PHP versions prior to 7.0.
Commits
-------
352c01a0 Remove legacy exception catches from 2.x
This PR was merged into the 2.x branch.
Discussion
----------
Use null rather than specific length for 'to the end' in mb_substr
We use Twig with a ISO-8859-15 charset and noticed the 'capitalize'-method only yielded the first character of a string. I.e. "abcd" became "A" rather than "Abcd".
This was due to a change in the way mb_substr is used. Appearantly, using 2147483647 as a length to indicate 'everything to the end' only works with UTF-8 (and possibly other multibyte charsets). It probably triggers some internal overflow in php for at least ASCII and ISO-8859-15.
Luckily, an easy fix is available since PHP 5.4.8: just use 'null'
See these two tests for which version does what:
(old) https://3v4l.org/qdpIK
(new) https://3v4l.org/kivqK
I also used null in the slice-method. While it did not suffer from this same issue, it did an unnecessary mb_strlen. And there might be similar overflow issues with negative values of $start, but I didn't actually test that.
Commits
-------
3bea610e Use null rather than specific length for 'all characters to the end' with mb_substr
This PR was merged into the 2.x branch.
Discussion
----------
do not overridde case-insentive cache entries
This will fix#2343.
Commits
-------
2c153bd1 do not overridde case-insentive cache entries
This PR was merged into the 1.x branch.
Discussion
----------
Turned fatal error into exception when a previously generated cache prevents loading its newly compiled version
Not sure if this is testable, yet this should save some hours to people that end up in the same trap we did on our project.
It turned out we generated some twig template cache in two separate commands, in a situation where "index" tracking for embeds where lost.
This PR detects the situation and invites to clear the cache properly, because that's the only way to fix the issue.
It also fixes a mistake in the cache $key generation, that should not take $index into account.
Doing so were making offline cache warmup useless in some situations.
Commits
-------
95c10991 Turned fatal error into exception when a previously generated cache prevents loading its newly compiled version
Antony D'Andrea
Fabien Potencier
Vincent Dechenaux
Robin Chalas
Victor Bocharsky
Peter Potrowl
Stéphane Lavergne
SpacePossum
Arjen van der Meijden
Christian Flothmann
Nicolas Grekas