This PR was merged into the 2.0-dev branch.
Discussion
----------
remove php 5.2 compatibility for filesystemhelper
#1945 for 2.x
Commits
-------
4ce9587 remove php 5.2 compatibility for filesystemhelper
* 1.x: (22 commits)
skip read-only dir tests on windows and cleanup tmp dirs correctly
Fixing a slight typo in interface
made a small refactoring
fixed typo
deprecated a class that has never been used
bumped version to 1.23.2-DEV
prepared the 1.23.1 release
updated CHANGELOG
Add dot to the end of exception messages.
set back default
Typo in doc
CS
static vs. self
Code grooming
fix deprecation message typo
fixed typos
fixed CS
fix BC, revert to pre 1.23 behavior, and make use of pattern an option
make cache per user (on linux)
fixed Twig_Extension_GlobalsInterface name in comments
...
This PR was squashed before being merged into the 1.x branch (closes#1945).
Discussion
----------
skip read-only dir tests on windows and cleanup tmp dirs correctly
- fix tests on windows (skipping them as read-only dirs are not possible on windows, only read-only files; read-only attribute on folders (`exec('attrib +R '`) does not prevent files to be created inside them)
- correctly cleanup tmp directories at the end of tests
Commits
-------
c6601a1 skip read-only dir tests on windows and cleanup tmp dirs correctly
This PR was merged into the 1.x branch.
Discussion
----------
Fixing a slight typo in interface
Just a typo in the ExtensionInterface
Commits
-------
de15975 Fixing a slight typo in interface
This PR was merged into the 1.x branch.
Discussion
----------
Code grooming
Commits
-------
aa7c53a Add dot to the end of exception messages.
b8a6e72 set back default
0f5f9aa Typo in doc
8bb9b83 CS
355213b static vs. self
d4e3ada Code grooming
This PR was merged into the 1.x branch.
Discussion
----------
made exception messages more precise
Replaces #1906 and #1902
Commits
-------
04d6738 fixed typos
This PR was merged into the 1.x branch.
Discussion
----------
fix BC, revert to pre 1.23 behavior, and make use of pattern an option
For context see twigphp/Twig-extensions#155
Commits
-------
ee5e25e fix BC, revert to pre 1.23 behavior, and make use of pattern an option
This PR was merged into the 1.x branch.
Discussion
----------
fixed Twig_Extension_GlobalsInterface name in comments
It looks like renaming `Twig_Extension_GlobalsProviderInterace` to `Twig_Extension_GlobalsInterface` was done only partially while working on #1897.
Commits
-------
2660286 fixed Twig_Extension_GlobalsInterface name in comments
This PR was merged into the 1.x branch.
Discussion
----------
make cache per user (on linux)
Just because I hate having failed test when I run test once on 1 account, then once on another account ;)
Commits
-------
da5cac6 make cache per user (on linux)
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_ExtensionInterface::getGlobals()
Commits
-------
e3a325f deprecated Twig_ExtensionInterface::getGlobals()
This PR was merged into the 1.x branch.
Discussion
----------
deprecated the possibility to override an extension by registering an other one with the same name
Commits
-------
72485c2 deprecated the possibility to override an extension by registering another one with the same name
This PR was merged into the 1.x branch.
Discussion
----------
deprecated Twig_ExtensionInterface::initRuntime()
I'm working on splitting Twig extensions into 2 different phases: compilation and runtime. The goal is to avoid having to load the runtime environment of an extension when compiling templates. That also opens the way to be able to lazy-load Twig extensions.
While working on the split, I realized that the `initRuntime()` method on `Twig_ExtensionInterface` is not needed anymore. It was added at a time `needs_environment` did not exist and was a way to keep the environment around for custom filters/tests/functions. But nowadays, that's not needed anymore. I did a quick search on Github, and most of the implementation I found just store the environment in a local property, which is not needed anymore. So, I propose to deprecate it in 1.x and remove it in 2.0.
Commits
-------
9774f4f deprecated Twig_ExtensionInterface::initRuntime()
This PR was merged into the 2.0-dev branch.
Discussion
----------
iconv, mbstring, and polyfill
Commits
-------
08341ec removed unneeded conditions for a null charset
aca92bc fixed Windows support
f5cf424 added the Symfony mbstring polyfill
4004a2b removed condition on iconv as it should be always available
Fabien Potencier
Tobias Schultze
Martin Hasoň
Jez Emery
Possum
Richard van Laak
Remi Collet
Christian Raue