This PR was merged into the master branch.
Discussion
----------
Fix issue #1143
Commits
-------
5042159 [ext] access static properties, fixed#1143dfc335f Added test case for issue #1143
This PR was merged into the master branch.
Discussion
----------
fix numeric & boolean & float keys in array
Reopened PR of #878
Commits
-------
2c56b70 Merge pull request #3 from tucksaun/patch-1
17d6cc7 [ext] fixed tabs
46012ce [ext] improvements
21f8062 [ext] code cleaning
9347c52 [ext] updated PHP code documenting C code
b41ce60 updated C extension accordingly
e5291e1 rename item to attribute in the exception message because that's the term that is used in twig, e.g. the function
a93f0dc further improved exception message and distinguish array_call and any_call access
26bac14 added tests for array access with confusable keys
db744d5 fix test that that would not fail if no exception is thrown
9ea16ec refactored getAttribute
6fb5afa improved error message for non-existent or invalid attributes
fdfd506 added changelog entry about fixed boolean array access
da616c5 fixed getAttribute for array access with a boolean or float key
b6acf9d updated CHANGELOG
c4d5b3f added some unit tests for previous merge
e84448b fix numeric keys in array
- Fix extension memory leak
- Fix gcc compile warning (cast to const char *)
- Add TWIG_HAS_DYNAMIC_PROPERTY
- Remove the previous translation of 'array_key_exists($item, $object)'
into TWIG_ARRAY_KEY_EXISTS when checking object property because what
it really means is property_exists which has already been handled by
TWIG_HAS_PROPERTY and TWIG_HAS_DYNAMIC_PROPERTY
- Fix native extension spacing
Commits
-------
8fa97bb php5.2 fix
d6fc86a [Tests] Test accessing a public property when \ArrayAccess is implemented
6704227 [ext] made ext consistent with 8ec73cf475228d2b0 [ext] use only read_property handler
Discussion
----------
Alternative fix for 792
This fixes#792 as described in https://github.com/fabpot/Twig/issues/792#issuecomment-7482480
- 228d2b0 removes the *object-to-array convertion* trick, since the bug comes from there, and it doesn't appear to be needed
- 6704227 is the equivalent of aa6b835816 + 8ec73cf475 (this were not needed before because the bug was hidden by the object to array trick: numeric strings and integers are treated equally in arrays keys)
---------------------------------------------------------------------------
by stof at 2012-08-23T10:19:17Z
@arnaud-lb you need to fix the PHP 5.2 support
Commits
-------
9e6f285 fixed crash in twig_template_get_attributes when input is not an array or object
Discussion
----------
Fix crash in twig_template_get_attributes when input is not an array or object
This fixes a crash when the input of twig_template_get_attributes() is not an array or object, and strict mode is enabled.
---------------------------------------------------------------------------
by nikic at 2011/12/16 12:03:21 -0800
Could you maybe place the exception tests in a different method?
---------------------------------------------------------------------------
by arnaud-lb at 2011/12/16 12:13:35 -0800
This method already expects many of its inputs to cause an exception to be thrown (it tests getAttribute() in strict mode, and in many cases the attribute isn't defined). I don't see a real benefit from moving these tests in a separate method in this case.
Commits
-------
c920344 code style
50da1a2 don't modify function name
Discussion
----------
Fix crash in extension
This fixes a crash caused by `php_strtolower()` modifying its input. (Crashes on amd64, but not on x86 for me.)
The callbacks are expected to return an integer, and returning void
instead was triggering weird bugs
I've also removed the casts to ensure that the signatures are compatible
Tugdual Saunier
Fabien Potencier
Arjen Brouwer
Charles
Pierre Joye
Anatoliy Belsky
Arnaud Le Blanc
stealth35
Sergey Linnik