Commits
-------
c53a02d Fixed DateTimeZone support in date filter.
Discussion
----------
Fixed DateTimeZone support in date filter.
Now $date converted to a DateTime has a DateTimeZone in every case.
---------------------------------------------------------------------------
by fabpot at 2012-05-28T19:20:47Z
Can you add some unit tests to avoid regression to happen later? Thanks.
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T07:52:58Z
@fabpot Here they are.
---------------------------------------------------------------------------
by fabpot at 2012-05-29T10:29:28Z
Great! Can you add a note in the CHANGELOG file and then squash your commit before I merge? Thanks.
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T12:52:22Z
Changelog added. First squash of my life, i cannot say if it's good :(
---------------------------------------------------------------------------
by stof at 2012-05-29T12:55:26Z
it is not. you merged your remote branch instead of forcing the push
---------------------------------------------------------------------------
by blaugueux at 2012-05-29T17:12:05Z
Ok @stof, thanks for your help. I think it's good now.
@fabpot Is it ok for you ?
PHP DateTime objects are mutable so changing the timezone when displaying
it affects the following code whereas it does not occur for other
supported formats.
Commits
-------
07f13df fixed typo
0f623a1 added the parent as an argument to the embed tag (removes the need to use extends)
fab21d8 renamed the inline tag to embed
1b54780 tweaked examples
955726a changed the inline examples to not use even/odd to avoid confustion
fb07f3a renamed indice to index
fafde80 added more info in the docs
2fa8224 added the inline tag
Discussion
----------
added the inline tag
At Sensio, we manage websites with many mostly-static pages that share almost the same structure (with different content of course), but with some subtle differences. After trying many different possibilities (external templates, inheritance, macros, and some ugly ones that I won't even tell you about ;)) to structure our templates, we came to the conclusion that we needed a new concept.
This new concept is implemented via a new tag, `inline`, which I want to include in Twig 1.8 (not for the upcoming 1.7 which is due this week). But before merging this code into master, I want to gather some feedback from the community. One of my questions being: Will you use this new possibility?
I won't tell you more here as the tag is fully documented in the diff.
---------------------------------------------------------------------------
by oojacoboo at 2012-04-23T17:58:59Z
odd/even? What other potential uses do you see? I think I can see a couple, but generally speaking, unless it's a content site (ie. blog), the odd/even isn't very useful. Reusing blocks even with minor customizations on a per page level is highly needed for our development processes, but an odd/even scenario is certainly not.
Maybe I'm missing something here. What about passing attributes to a block or something?
---------------------------------------------------------------------------
by fabpot at 2012-04-23T18:02:51Z
@oojacoboo odd/even is just an example. Of course, this is not a real use case, this was just an attempt to find an example.
---------------------------------------------------------------------------
by stof at 2012-04-23T18:03:53Z
@oojacoboo there is no reference to odd/even in the code, only in the doc
---------------------------------------------------------------------------
by simensen at 2012-04-23T18:20:10Z
I think that it would be useful in some cases. I can't think of any places I could use it *right now* but I know I've had to jump through hoops on more than a few occasions to get things to work correctly. Being able to keep functionality like this in mind at the design stage might have made things easier in a few of those cases.
---------------------------------------------------------------------------
by lyrixx at 2012-04-23T18:21:34Z
I think it's a good idea.
---------------------------------------------------------------------------
by tyomo4ka at 2012-04-23T18:25:07Z
I think it will be great. Each time when I need to include templat that simple extends another one and replace one small block I think: "Why I should to create new template for it?". Thanks, @fabpot
---------------------------------------------------------------------------
by bmatzner at 2012-04-23T18:28:23Z
Right on. +1
---------------------------------------------------------------------------
by cranberyxl at 2012-04-23T18:40:17Z
I believe the concept is a good one, but the example using even and odd will confuse frontend developers because it's usually used in the context of loops and table striping. even changing it to styleA.twig and styleB.twig would be more understandable.
---------------------------------------------------------------------------
by lyrixx at 2012-04-23T19:01:32Z
@cranberyxl +1
---------------------------------------------------------------------------
by fabpot at 2012-04-23T19:24:21Z
ok, I've just changed the examples to not used even/odd.
---------------------------------------------------------------------------
by jorgelbg at 2012-04-23T19:27:53Z
I think that the inline tag is a valid concept, but still I can't get it landed on a real case!
---------------------------------------------------------------------------
by sirowl at 2012-04-23T19:35:07Z
As a webdesigner with a steady foundation in CSS I find the term inline very confusing, I had to consult a developer to actually understand what was the idea of the tag as I so heavily associated it with CSS's terminology of inline.
The CSS terminololigy got me on the wrong track in terms of what the tag was supposed to be used for.
I have no good suggestion for a name for it, but inline could probably get very confusing for a lot of webdesigners making use of twig.
---------------------------------------------------------------------------
by fabpot at 2012-04-23T19:41:48Z
@sirowl `inline` was the best term I could come up with but I'm open to any other suggestion.
---------------------------------------------------------------------------
by sirowl at 2012-04-23T19:47:30Z
The best I could come up with is embed, as it is an embedded document of sorts.. or something along those lines.
---------------------------------------------------------------------------
by bschussek at 2012-04-23T19:48:54Z
I like `embed`.
---------------------------------------------------------------------------
by bmatzner at 2012-04-23T19:55:37Z
Hi Fabien, inline makes sense to me, although I understand @sirowl's comment, but I even find the concept quite comparable to the CSS display:block/display:inline logic. @sirowl's suggestion of "embed" would be just as fine, as it's just a matter of learning what this particular tag refers to. The ambiguation against the import tag is probably the most crucial, explaining the advantages of "inline" (or whatever) over doing an import
---------------------------------------------------------------------------
by Baachi at 2012-04-23T20:03:26Z
I lke ```embed```, too.
---------------------------------------------------------------------------
by Nami-Doc at 2012-04-23T20:11:42Z
I like `embed`, but `inline` is fine too.
---------------------------------------------------------------------------
by tijuan at 2012-04-23T20:36:39Z
I like the feature
I like embed
---------------------------------------------------------------------------
by pulse00 at 2012-04-23T20:56:41Z
+1 for `embed`
---------------------------------------------------------------------------
by mickaelandrieu at 2012-04-24T00:35:01Z
I like embed, inline for me is an CSS behavior
---------------------------------------------------------------------------
by matheo at 2012-04-24T04:29:05Z
+1 for `embed`
---------------------------------------------------------------------------
by fabpot at 2012-04-24T05:35:06Z
I've just renamed the `inline` tag to `embed`.
---------------------------------------------------------------------------
by sirowl at 2012-04-24T06:55:17Z
@fabpot agreed, much more clear to me now. Look forward to using it.
---------------------------------------------------------------------------
by pvanliefland at 2012-04-24T07:20:35Z
I would like to use this feature as well
---------------------------------------------------------------------------
by tristanbes at 2012-04-24T07:38:57Z
So if I take another example, to help me understand better
I do have a common structure stated as follows :
```
<body>
<div class="row">
<div class="main">
<div id="homepage">
{% block content %}
</div>
</div>
</div>
</body>
```
Let's say for the other pages, the `id="homepage"` is replaced by `id="innerPage"` `id="specialLayout"`
So far I created 3 base template with those changes, so with the new `embed` tag, does this concept fits here or I misunderstood the function of `embed` feature ?
---------------------------------------------------------------------------
by ruian at 2012-04-24T07:47:38Z
@tristanbes with `embed`, you can "include" another twig template and modify directly these differents `block`.
If you want to understand you can read `embed` tests https://github.com/fabpot/Twig/blob/0f623a11129ce28a897dbd5b812241d8b3ea9730/test/Twig/Tests/Fixtures/tags/embed/
---------------------------------------------------------------------------
by samuelmichaud at 2012-04-24T08:02:42Z
Yes ! I will definitely use this ! Thanks
---------------------------------------------------------------------------
by michelsalib at 2012-04-24T08:05:47Z
As @samuelmichaud said we have some uses cases (such as menu generation, breadcrumbs or quick action embedding). So this feature makes total sense.
Commits
-------
c88f8e5 Micro-optimizations
70cca66 Simplify code
d78ed66 Add traversable test
5fd2f98 Add docs
b2e1675 Add is array test
Discussion
----------
is array/traversable tests
It's sometimes necessary to display arbitrary data to be able to know if we should recurse or not.
---------------------------------------------------------------------------
by stof at 2012-04-13T12:13:11Z
I'm not sure about the need for ``is array``. All Twig functions related to arrays also support traversable objects
---------------------------------------------------------------------------
by Seldaek at 2012-04-13T12:23:32Z
Well, I like to have both for explicitness and also because I would try is array without looking at the docs, and I don't think it's right to make is array return true for traversables.
---------------------------------------------------------------------------
by fabpot at 2012-04-20T09:38:33Z
One of the main goal of Twig is to abstract the "real" type of the variables. We have already discussed the introduction of many tests like these ones and I have always rejected them.
As many people seems to have a need for them (especially for arrays), I would consider adding the `traversable` test. But as @stof said, Twig tries to blur the difference between traversable objects and arrays, so I'm -1 for adding another test for arrays.
`traversable` is probably not the best name for web designers but I don't know what else we can use here.
---------------------------------------------------------------------------
by stof at 2012-04-20T09:41:05Z
In Jinja, there is a built-in test for this using ``iterable``: http://jinja.pocoo.org/docs/templates/#builtin-tests
---------------------------------------------------------------------------
by Seldaek at 2012-04-20T09:41:32Z
Ok. I can live with dropping the array test. Now for the name, `is forloopable`? I am kind of at a loss as well apart from traversable. I think if it's clearly mentioned in the docs it's ok.
---------------------------------------------------------------------------
by Seldaek at 2012-04-20T09:52:12Z
iterable sounds ok to me, but just as confusing as traversable I guess to the unknowing. A sidenote, if I update the PR, any objection to adding the "undefined" test as well?
---------------------------------------------------------------------------
by fabpot at 2012-04-20T10:01:27Z
Let's use `iterable` as this is what Jinja already uses. Why would you want an `undefined` test as we already have `defined`? (`if foo is not defined` works well enough)
---------------------------------------------------------------------------
by Seldaek at 2012-04-20T11:16:26Z
I just saw jinja had it on that page, and I thought why not add it too? Still not a huge fan of the "not" for negation.
---------------------------------------------------------------------------
by fabpot at 2012-04-20T12:18:17Z
Well, let's first finish the `iterable` test first and let's discuss `undefined` in another PR or issue.
---------------------------------------------------------------------------
by fabpot at 2012-04-20T17:10:28Z
I can finish the PR is you want.
---------------------------------------------------------------------------
by Seldaek at 2012-04-20T17:13:11Z
If you like sure, it's mostly deleting code anyway. I just have to finish some work stuff now..
Commits
-------
0cbf5a0 Added an option to mark filters as preserving the safeness
Discussion
----------
Added an option to mark filters as preserving the safeness
Closes#678
I haven't written a test for this yet as I don't know how to provide a stub filter (as none of the core filters use this option) for the setup of the testsuite.
---------------------------------------------------------------------------
by fabpot at 2012-04-07T20:15:36Z
@stof: Can you also add some information in the phpdoc with an example so that people understand more easily when and why you would want to use this new option? Thanks.
---------------------------------------------------------------------------
by fabpot at 2012-04-07T20:16:36Z
Also, adding a unit test that demonstrates the bug you had in #678 would be good.
---------------------------------------------------------------------------
by stof at 2012-04-20T08:33:58Z
@fabpot none of the core filters are using this options, so what is the right way to add a test ?
---------------------------------------------------------------------------
by fabpot at 2012-04-20T08:36:26Z
by defining a filter in the test that uses it.
---------------------------------------------------------------------------
by stof at 2012-04-20T08:39:06Z
but is it possible to register a filter from the tests with the custom stuff used by Twig ?
---------------------------------------------------------------------------
by fabpot at 2012-04-20T08:48:06Z
in integrationTest.php, we already have quite a few functions and filters registered. I would just be a matter of adding a new one.
---------------------------------------------------------------------------
by stof at 2012-04-20T16:17:01Z
@fabpot renamed, tested and squashed
Fabien Potencier
Benjamin Laugueux
Maarten de Keizer
Christophe Coevoet
Martin Hasoň
Jordi Boggiano
Tobias Schultze