geckon01/TwoFactorAuth
1
0
Fork 0
mirror of https://github.com/RobThree/TwoFactorAuth.git synced 2026-08-19 00:03:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

add SensitiveParameter to sensitive arguments

Browse Source 
This change adds the PHP attribute SensitiveParameter to the secret
holding variables.
See: https://www.php.net/manual/en/class.sensitiveparameter

This feature is only available in PHP 8.2, so the minimum php version
required has been updated.

Github Actions now use PHP 8.2 and 8.3 for the tests.
The checkout action has been updated to v4, too.

Fix issue #118
This commit is contained in:
Nicolas CARPi
2024-04-15 21:40:19 +02:00
parent ab93dd41ce
commit 76f420e6b2
8 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/TwoFactorAuth.php
+3 -3
View File
@@ -69,7 +69,7 @@ class TwoFactorAuth
/**
* Calculate the code with given secret and point in time
*/
public function getCode(string $secret, ?int $time = null): string
public function getCode(#[\SensitiveParameter] string $secret, ?int $time = null): string
{
$secretkey = $this->base32Decode($secret);
@@ -107,7 +107,7 @@ class TwoFactorAuth
/**
* Get data-uri of QRCode
*/
public function getQRCodeImageAsDataUri(string $label, string $secret, int $size = 200): string
public function getQRCodeImageAsDataUri(string $label, #[\SensitiveParameter] string $secret, int $size = 200): string
{
if ($size <= 0) {
throw new TwoFactorAuthException('Size must be > 0');
@@ -153,7 +153,7 @@ class TwoFactorAuth
/**
* Builds a string to be encoded in a QR code
*/
public function getQRText(string $label, string $secret): string
public function getQRText(string $label, #[\SensitiveParameter] string $secret): string
{
return 'otpauth://totp/' . rawurlencode($label)
. '?secret=' . rawurlencode($secret)