fix(loader): multiprocessing.set_start_method once, queue for plugin import

This commit is contained in:
Jonas Dellinger
2022-06-13 10:57:16 +02:00
parent 12f4c7faff
commit a95bf94d87
3 changed files with 33 additions and 12 deletions
+1 -1
View File
@@ -10,6 +10,7 @@ from signal import SIGINT, signal
from sys import exit from sys import exit
from time import time from time import time
multiprocessing.set_start_method("fork")
class PluginWrapper: class PluginWrapper:
def __init__(self, file, plugin_directory, plugin_path) -> None: def __init__(self, file, plugin_directory, plugin_path) -> None:
@@ -87,7 +88,6 @@ class PluginWrapper:
def start(self): def start(self):
if self.passive: if self.passive:
return self return self
multiprocessing.set_start_method("fork")
multiprocessing.Process(target=self._init).start() multiprocessing.Process(target=self._init).start()
return self return self
+2 -1
View File
@@ -31,7 +31,8 @@
}, },
"importSort": { "importSort": {
".js, .jsx, .ts, .tsx": { ".js, .jsx, .ts, .tsx": {
"style": "module" "style": "module",
"parser": "typescript"
} }
}, },
"dependencies": { "dependencies": {
+20
View File
@@ -21,6 +21,10 @@ class PluginLoader extends Logger {
private routerHook: RouterHook = new RouterHook(); private routerHook: RouterHook = new RouterHook();
private deckyState: DeckyState = new DeckyState(); private deckyState: DeckyState = new DeckyState();
private reloadLock: boolean = false;
// stores a list of plugin names which requested to be reloaded
private pluginReloadQueue: string[] = [];
constructor() { constructor() {
super(PluginLoader.name); super(PluginLoader.name);
this.log('Initialized'); this.log('Initialized');
@@ -68,6 +72,13 @@ class PluginLoader extends Logger {
} }
public async importPlugin(name: string) { public async importPlugin(name: string) {
try {
if (this.reloadLock) {
this.log('Reload currently in progress, adding to queue', name);
this.pluginReloadQueue.push(name);
return;
}
this.log(`Trying to load ${name}`); this.log(`Trying to load ${name}`);
let find = this.plugins.find((x) => x.name == name); let find = this.plugins.find((x) => x.name == name);
if (find) this.plugins.splice(this.plugins.indexOf(find), 1); if (find) this.plugins.splice(this.plugins.indexOf(find), 1);
@@ -79,6 +90,15 @@ class PluginLoader extends Logger {
this.log(`Loaded ${name}`); this.log(`Loaded ${name}`);
this.deckyState.setPlugins(this.plugins); this.deckyState.setPlugins(this.plugins);
} catch (e) {
throw e;
} finally {
this.reloadLock = false;
const nextPlugin = this.pluginReloadQueue.shift();
if (nextPlugin) {
this.importPlugin(nextPlugin);
}
}
} }
private async importReactPlugin(name: string) { private async importReactPlugin(name: string) {