From c8e57594c5eae545d7389cef736f3aeb832bf62a Mon Sep 17 00:00:00 2001
From: LearningCircuit <185559241+LearningCircuit@users.noreply.github.com>
Date: Mon, 25 May 2026 00:27:13 +0200
Subject: [PATCH] test: delete 10 hasattr-only tests in
 test_research_metrics_extended.py (#4277)

---
 .../metrics/test_research_metrics_extended.py | 89 -------------------
 1 file changed, 89 deletions(-)

diff --git a/tests/metrics/test_research_metrics_extended.py b/tests/metrics/test_research_metrics_extended.py
index 25217069d..09942b2a0 100644
--- a/tests/metrics/test_research_metrics_extended.py
+++ b/tests/metrics/test_research_metrics_extended.py
@@ -80,13 +80,6 @@ class TestResearchMetrics:
         )
         assert cache_hit_rate > 0.7
 
-    def test_search_latency_metrics(self):
-        """Test search latency is captured"""
-        from local_deep_research.metrics.search_tracker import SearchTracker
-
-        # SearchTracker records latency
-        assert hasattr(SearchTracker, "record_search")
-
     def test_llm_latency_metrics(self):
         """Test LLM latency is tracked"""
         from local_deep_research.metrics.token_counter import (
@@ -120,14 +113,6 @@ class TestResearchMetrics:
 
         assert callback.research_context["memory_usage_mb"] == 256
 
-    def test_database_query_metrics(self):
-        """Test database interaction metrics"""
-        # Test database model exists
-        from local_deep_research.database.models import TokenUsage
-
-        assert hasattr(TokenUsage, "research_id")
-        assert hasattr(TokenUsage, "response_time_ms")
-
     def test_socket_emit_metrics(self):
         """Test socket emission tracking"""
         from local_deep_research.metrics.token_counter import (
@@ -500,18 +485,6 @@ class TestQueryUtils:
 class TestSearchTracker:
     """Tests for search tracking functionality"""
 
-    def test_search_tracker_exists(self):
-        """Test SearchTracker class exists"""
-        from local_deep_research.metrics.search_tracker import SearchTracker
-
-        assert SearchTracker is not None
-
-    def test_record_search_method(self):
-        """Test record_search method exists"""
-        from local_deep_research.metrics.search_tracker import SearchTracker
-
-        assert hasattr(SearchTracker, "record_search")
-
     @patch("local_deep_research.metrics.search_tracker.SearchTracker")
     def test_get_search_metrics(self, mock_tracker):
         """Test getting search metrics"""
@@ -528,36 +501,6 @@ class TestSearchTracker:
 class TestCostCalculator:
     """Tests for cost calculation"""
 
-    def test_cost_calculator_exists(self):
-        """Test CostCalculator exists"""
-        from local_deep_research.metrics.pricing.cost_calculator import (
-            CostCalculator,
-        )
-
-        assert CostCalculator is not None
-
-    def test_get_model_pricing(self):
-        """Test getting model pricing"""
-        from local_deep_research.metrics.pricing.cost_calculator import (
-            CostCalculator,
-        )
-
-        calc = CostCalculator()
-
-        # Should have pricing data
-        assert hasattr(calc, "get_model_pricing")
-
-    def test_calculate_cost(self):
-        """Test cost calculation"""
-        from local_deep_research.metrics.pricing.cost_calculator import (
-            CostCalculator,
-        )
-
-        calc = CostCalculator()
-
-        # Should have calculate method
-        assert hasattr(calc, "calculate_cost")
-
     def test_local_model_free(self):
         """Test local models are free"""
         from local_deep_research.metrics.pricing.pricing_fetcher import (
@@ -573,35 +516,3 @@ class TestCostCalculator:
         # If no pricing info, default should be 0
         assert pricing.get("input_cost", 0) == 0
         assert pricing.get("output_cost", 0) == 0
-
-
-class TestDatabaseModels:
-    """Tests for database model structure"""
-
-    def test_token_usage_model(self):
-        """Test TokenUsage model fields"""
-        from local_deep_research.database.models import TokenUsage
-
-        # Check required fields exist
-        assert hasattr(TokenUsage, "id")
-        assert hasattr(TokenUsage, "research_id")
-        assert hasattr(TokenUsage, "prompt_tokens")
-        assert hasattr(TokenUsage, "completion_tokens")
-        assert hasattr(TokenUsage, "total_tokens")
-        assert hasattr(TokenUsage, "timestamp")
-
-    def test_model_usage_model(self):
-        """Test ModelUsage model fields"""
-        from local_deep_research.database.models import ModelUsage
-
-        assert hasattr(ModelUsage, "id")
-        assert hasattr(ModelUsage, "model_name")
-        assert hasattr(ModelUsage, "model_provider")
-
-    def test_search_call_model(self):
-        """Test SearchCall model exists"""
-        from local_deep_research.database.models.metrics import SearchCall
-
-        assert hasattr(SearchCall, "id")
-        assert hasattr(SearchCall, "research_id")
-        assert hasattr(SearchCall, "search_engine")