Files
local-deep-research/.github/workflows/codeql.yml
LearningCircuit bfd54d0ca2 fix: Remove redundant job-level permissions in 7 security workflows
Resolves 7 OSSF Scorecard HIGH severity alerts for token permissions.

## Changes

### Workflows Fixed:
1. codeql.yml - Removed job-level permissions, added packages:read and actions:read to top-level
2. container-security.yml - Removed job-level permissions from both jobs, added actions:read to top-level
3. devskim.yml - Removed job-level permissions, added actions:read to top-level
4. docker-publish.yml - Removed packages:write (not needed for Docker Hub)
5. gitleaks.yml - Removed job-level permissions, added actions:read to top-level
6. hadolint.yml - Removed job-level permissions, added pull-requests:write to top-level
7. semgrep.yml - Removed job-level permissions, added actions:read to top-level

## Problem

OSSF Scorecard flagged these workflows for having both top-level and job-level
permissions declarations. This pattern can lead to:
- Permission confusion and misconfiguration
- Potential privilege escalation if not carefully managed
- Violation of principle of least privilege best practices

## Solution

- Consolidated all required permissions at the top-level only
- Removed redundant job-level permission blocks
- Added necessary permissions (actions:read, packages:read, pull-requests:write) to top-level where needed
- Reduced docker-publish.yml from packages:write to contents:read (only publishing to Docker Hub, not GHCR)
- Added explanatory comments for each permission

## Security Impact

 Resolves 7 OSSF Scorecard HIGH severity alerts
 Implements principle of least privilege
 Reduces permission confusion across workflows
 Maintains all necessary functionality
 Consistent with GitHub security best practices

## Testing

- All workflows maintain same functionality with centralized permissions
- No changes to actual workflow logic or steps
- Permissions properly scoped to minimum requirements
2025-11-24 20:29:13 +01:00

96 lines
4.5 KiB
YAML
Raw Blame History

This file contains invisible Unicode characters
This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL Advanced"
on:
push:
branches: [ "main", "dev" ]
pull_request:
branches: [ "main", "dev" ]
schedule:
- cron: '45 5 * * 0'
permissions:
contents: read
security-events: write
packages: read # Required to fetch CodeQL packs
actions: read # Required for private repositories
jobs:
analyze:
name: Analyze (${{ matrix.language }})
# Runner size impacts CodeQL analysis time. To learn more, please see:
# - https://gh.io/recommended-hardware-resources-for-running-codeql
# - https://gh.io/supported-runners-and-hardware-resources
# - https://gh.io/using-larger-runners (GitHub.com only)
# Consider using larger runners or machines with greater resources for possible analysis time improvements.
runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
strategy:
fail-fast: false
matrix:
include:
- language: javascript-typescript
build-mode: none
- language: python
build-mode: none
# CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift'
# Use `c-cpp` to analyze code written in C, C++ or both
# Use 'java-kotlin' to analyze code written in Java, Kotlin or both
# Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both
# To learn more about changing the languages that are analyzed or customizing the build mode for your analysis,
# see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning.
# If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how
# your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages
steps:
- name: Checkout repository
uses: actions/checkout@v5.0.0
# Add any setup steps before running the `github/codeql-action/init` action.
# This includes steps like installing compilers or runtimes (`actions/setup-node`
# or others). This is typically only required for manual builds.
# - name: Setup runtime (example)
# uses: actions/setup-example@v1
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v4.31.2
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
# queries: security-extended,security-and-quality
# If the analyze step fails for one of the languages you are analyzing with
# "We were unable to automatically build your code", modify the matrix above
# to set the build mode to "manual" for that language. Then modify this step
# to build your code.
# Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
- if: matrix.build-mode == 'manual'
shell: bash
run: |
echo 'If you are using a "manual" build mode for one or more of the' \
'languages you are analyzing, replace this with the commands to build' \
'your code, for example:'
echo ' make bootstrap'
echo ' make release'
exit 1
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v4.31.2
with:
category: "/language:${{matrix.language}}"