:octocat: improved Kanji validation (fingers crossed)

tests/Data/KanjiTest.php

@@ -11,6 +11,8 @@
 namespace chillerlan\QRCodeTest\Data;
 
 use chillerlan\QRCode\Data\Kanji;
+use Throwable;
+use function array_map, bin2hex, chr, defined, mb_internal_encoding, sprintf;
 
 /**
  * Tests the Kanji class
@@ -18,7 +20,7 @@ use chillerlan\QRCode\Data\Kanji;
 final class KanjiTest extends DataInterfaceTestAbstract{
 
 	protected string $FQN      = Kanji::class;
-	protected string $testdata = '茗荷茗荷茗荷茗荷茗荷';
+	protected string $testdata = '漂う花の香り';
 
 	/**
 	 * isKanji() should pass on Kanji/SJIS characters and fail on everything else
@@ -26,10 +28,77 @@ final class KanjiTest extends DataInterfaceTestAbstract{
 	public function stringValidateProvider():array{
 		return [
 			['茗荷', true],
-			['Ã', false],
+			['Ã', false], // this will fail in SJIS-2004
 			['ABC', false],
 			['123', false],
+			['漂う花の香り', true], // https://genshin-impact.fandom.com/wiki/Floral_Incense
+			['꽃잎 향초의 기도', false], // same as above in korean
 		];
 	}
 
+	/**
+	 * lists the valid SJIS kanj
+	 */
+	public function kanjiProvider():array{
+		$list = [];
+
+		for($byte1 = 0x81; $byte1 < 0xeb; $byte1 += 0x1){
+
+			// skip invalid/vendor ranges
+			if(($byte1 > 0x84 && $byte1 < 0x88) || ($byte1 > 0x9f && $byte1 < 0xe0)){
+				continue;
+			}
+
+			// second byte of a double-byte JIS X 0208 character whose first half of the JIS sequence was odd
+			if(($byte1 % 2) !== 0){
+
+				for($byte2 = 0x40; $byte2 < 0x9f; $byte2++){
+
+					if($byte2 === 0x7f){
+						continue;
+					}
+
+					$list[] = [chr($byte1).chr($byte2)];
+				}
+
+			}
+			// second byte if the first half of the JIS sequence was even
+			else{
+
+				for($byte2 = 0x9f; $byte2 < 0xfd; $byte2++){
+					$list[] = [chr($byte1).chr($byte2)];
+				}
+
+			}
+
+		}
+
+		// we need to put the joined byte sequence in a proper encoding
+		return array_map(fn($chr) => mb_convert_encoding($chr, Kanji::sjisEncoding, Kanji::sjisEncoding), $list);
+	}
+
+	/**
+	 * @dataProvider kanjiProvider
+	 */
+	public function testValidateSJIS(string $kanji):void{
+
+		// we may run into several issues due to encoding detection failures
+		try{
+			$this::assertTrue(Kanji::validateString($kanji));
+		}
+		catch(Throwable $e){
+
+			/** @noinspection PhpUndefinedConstantInspection - see phpunit.xml.dist */
+			if(defined('TEST_IS_CI') && TEST_IS_CI === true){
+				$this::markTestSkipped();
+			}
+
+			$this::markTestSkipped(sprintf(
+				'invalid glyph: %s => %s',
+				bin2hex($kanji),
+				mb_convert_encoding($kanji, Kanji::sjisEncoding, mb_internal_encoding())
+			));
+		}
+	}
+
 }